Closed
Bug 632233
Opened 13 years ago
Closed 13 years ago
XULBrowserWindow.onLocationChange looks for a "disablefastfind" attribute in all content documents before ruling them out because their URI scheme isn't "about" or "chrome"
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 12
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
|
1.43 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Comment 1•13 years ago
|
||
My patch in bug 569342 performs the checks in a different order, so Gavin must have commented on it IRL, but I forget what the reasoning behind the change was.
|
||
Comment 2•13 years ago
|
||
Why does this matter? I wouldn't expect there to be a significant difference between docElt.getAttribute vs. the two schemeIs calls.
|
Assignee | |
Comment 3•13 years ago
|
||
The discussion in bug 384412 reminded me of this again. Even if it may end up not mattering, we should, on principle, access content as late as possible.
Attachment #585284 -
Flags: review?(gavin.sharp)
|
|
||
Updated•13 years ago
|
Attachment #585284 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/dd994bf80fc0
Target Milestone: --- → Firefox 12
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dd994bf80fc0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•