632432 - Editor review emails arriving with no subject

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

There are at least 2 cases where the review email was sent with no subject at all:

https://addons.mozilla.org/en-US/mobile/addon/near-me-271823/ (review on Jan 30th)
https://addons.mozilla.org/en-US/firefox/addon/TabCloud/ (review on Feb 7th)

We know it doesn't happen for all cases because we have received several recent replies with the correct subject.

Comment 1

[Wil Clouser [:clouserw]]

Where are the emails?

Comment 2

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> Where are the emails?

That's kind of vague - I mean, pasting in the emails here would help.  Also, are they all for a specific kind of event?  Or all have localized titles maybe? or have non en-US default locales?

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

What do you need from the emails for? The contents are correct, only the subject is blank.

The first review is Near Me 1.1, reviewed by Kris Maglione, Full Review denied but Granted Preliminary Review.

The second one is TabCloud 0.5, reviewed by Kris Maglione, Full Review denied but Granted Preliminary Review.

Both add-ons have a default en-US locale.

Comment 4

[Kris Maglione [:kmag]]

I've just gotten two more of these for https://addons.mozilla.org/en-US/editors/review/129297?num=31 and https://addons.mozilla.org/en-US/editors/review/128739?num=33

I'll note that for the second one, I apparently got logged out after I opened the review page but before I submitted the review and had to submit a second time, but I'm not sure if that's relevant.

Comment 5

[Justin Scott [:fligtar]]

I've seen 5 email threads with no subject on amo-editors since last night; we need to look into this sooner.

Comment 6

[Barry Chen]

Attachment: review e-mail subject for lite and nominated add-ons being set back to lite

It happens when an editor deny a full review on a nominated and preliminary reviewed add-on, setting it back to preliminary review.

The patch adds the missing line.

Comment 7

[Barry Chen]

Committed @ r84108.

Comment 8

[krupa raj[:krupa]]

On granting lite review to a nominated add-on, the email notification I received had the subject line- 'bar barsi 4.2 preliminarily reviewed'

marking this verified fixed