632547 - [traceback] SyntaxError: invalid syntax

Status: VERIFIED FIXED

(support.mozilla.org :: Localization, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://master.support.mozilla.com/sl/jsi18n//build:fe2f998 throws a traceback:

Traceback (most recent call last):

  File "/data/www/support.allizom.org/kitsune/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/support.allizom.org/kitsune/vendor/src/django/django/utils/decorators.py", line 76, in _wrapped_view
    response = view_func(request, *args, **kwargs)

  File "/data/www/support.allizom.org/kitsune/vendor/src/django/django/views/i18n.py", line 219, in javascript_catalog
    catalog = gettext_module.translation(domain, path, [locale])

  File "/usr/lib64/python2.6/gettext.py", line 480, in translation
    t = _translations.setdefault(key, class_(open(mofile, 'rb')))

  File "/usr/lib64/python2.6/gettext.py", line 180, in __init__
    self._parse(fp)

  File "/usr/lib64/python2.6/gettext.py", line 317, in _parse
    self.plural = c2py(plural)

  File "/usr/lib64/python2.6/gettext.py", line 126, in c2py
    return eval('lambda n: int(%s)' % plural)

  File "<string>", line 1

    lambda n: int((n%100==1. 0 : n%100==2. 1 : n%100==3  or  n%100==4. 2 : 3))

                             ^

SyntaxError: invalid syntax

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Hi Vito; mind taking a look at this?  Thanks!

Comment 2

[Vito Smolej]

The question marks have miracously changed into periods; 

the statement should instead of
lambda n: int((n%100==1. 0 : n%100==2. 1 : n%100==3  or  n%100==4. 2 : 3))

read like
lambda n: int((n%100==1 ? 0 : n%100==2 ? 1 : n%100==3  or  n%100==4 ? 2 : 3))
 
I am attaching the correct messages.po file - there was already trouble once with this same sentence. I have evidently corrected it to the worse. Sorry for extra work!

I will also upload a changed file into Verbatim, so that it will come down the pipeline without this error.

Regards

Vito

Comment 3

[Vito Smolej]

Attachment: messages.po with a corrected "plural-Forms" sentence

here's the messages.po file, corrected for the "period-instead-of-?" error:
"Content-Transfer-Encoding: 8bit\n"
""Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || n%100==4 ? 2 : 3);\n""
"X-Generator: Pootle 2.1.5\n"

Comment 4

[James Socol [:jsocol, :james]]

Vito, Kadir, can we please get this fixed today before our release?

Comment 5

[James Socol [:jsocol, :james]]

Oops, did not mean to resolve.

Comment 6

[Kadir Topal [:atopal]]

Hey Vito, was there an issue with checking-in into Verbatim? I'll need to do that now on my end, since we are pushing the new version today. I hope that it doesn't break anything with your tools. But let me know please if it does, and we can talk about how to avoid that in the future.

Comment 7

[James Socol [:jsocol, :james]]

Now we're getting "ValueError: plural forms expression error, maybe unbalanced parenthesis" errors again.

Comment 8

[Kadir Topal [:atopal]]

fixed, hopefully: r82649

Comment 9

[James Socol [:jsocol, :james]]

Ah, perhaps we were unclear: This is coming from javascript.po, not messages.po.

Comment 10

[James Socol [:jsocol, :james]]

r82650

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://support.allizom.org/sl/jsi18n/

Comment 12

[James Socol [:jsocol, :james]]

r82649 broke messages.po. Fixed in r82651.