632605 - Fix timestamps for comment data submitted to ElasticSearch

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Jonathan Griffin (:jgriffin)]

In working on a patch for bug 601743, I discovered I needed to change a little bit of the data that tbpl posts to ElasticSearch for comments.  Specifically, I need to use UTC for the 'date' field, to prevent us from getting a date in some random locale, and I need to add a 'timestamp' field, which is the time that the comment was submitted.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: patch

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 510828 [details] [diff] [review]
patch

(In reply to comment #0)
> and I need to add a 'timestamp' field, which is the time that
> the comment was submitted.

What's the advantage of taking the current time here instead of on the woo server side?

Comment 3

[Jonathan Griffin (:jgriffin)]

(In reply to comment #2)
> 
> What's the advantage of taking the current time here instead of on the woo
> server side?

No advantage; but since I needed to adjust this code to generate a UTC date for the startTime, I decided to add the timestamp here.

Pushed as http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/c929a1420853