632698 - when hidden, bookmarks menu button shouldn't appear when customizing toolbars

Status: RESOLVED DUPLICATE of bug 581238

(Firefox :: Toolbars and Customization, defect)

Description

[Frank Yan (:fryn)]

By default on Windows XP, we show the traditional menu bar. Because of this, we hide the bookmarks menu button. However, when opening the toolbar customization panel, the bookmarks menu button appears in the toolbar (then disappears upon panel closure)! This shouldn't happen.

Comment 1

[Dietrich Ayala (:dietrich)]

Non-primary UI, non-default settings - this does not sound severe enough to block the release.

Comment 2

[Frank Yan (:fryn)]

(In reply to comment #1)
> Non-primary UI, non-default settings - this does not sound severe enough to
> block the release.

As I explained above, the bug appears with the default settings. Start Firefox on XP, open customization panel, and there it is. Even so, this might not be enough to block.

Comment 3

[Dietrich Ayala (:dietrich)]

Ok. What's the actual effect of it showing that is the reason to block?

Comment 4

[Frank Yan (:fryn)]

(In reply to comment #3)
> Ok. What's the actual effect of it showing that is the reason to block?

It is confusing, bogus UI. A user starts Firefox 4 on XP for the first time with all default settings. The user wants to tweak the toolbars and opens the customization panel. The bookmarks menu button appears in the toolbar. The user is surprised and perhaps expects that the bookmarks menu button will remain there after the panel closes, but instead it disappears.

We may frustrate users by giving them something when they didn't expect or necessarily want it and then by taking it away without any obvious method of getting it back after the user perhaps realizes that he/she wants it.