Closed Bug 633332 Opened 13 years ago Closed 13 years ago

crash [@ nsCOMPtr_base::assign_assuming_AddRef | nsCOMPtr_base::assign_with_AddRef | nsHTMLMediaElement::Error]

Categories

(Core :: Audio/Video, defect)

All
Linux
defect
Not set
critical

Tracking

()

VERIFIED FIXED

People

(Reporter: jdm, Assigned: kinetik)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-71773692-0a4a-4e89-90a3-d0f472110209 .
============================================================= 

0 	libxul.so 	nsCOMPtr_base::assign_assuming_AddRef 	nsCOMPtr.h:474
1 	libxul.so 	nsCOMPtr_base::assign_with_AddRef 	nsCOMPtr.cpp:90
2 	libxul.so 	nsHTMLMediaElement::Error 	content/html/content/src/nsHTMLMediaElement.cpp:2005
3 	libxul.so 	nsHTMLMediaElement::LoadAborted 	content/html/content/src/nsHTMLMediaElement.cpp:1996
4 	libxul.so 	nsWaveDecoder::NotifyDownloadEnded 	content/media/wave/nsWaveDecoder.cpp:1552
5 	libxul.so 	DataEnded::Run 	content/media/nsMediaStream.cpp:723

We're looking at a null mElement in nsWaveDecoder, I believe.  Coincidentally, mElement is null-checked every single single place it's used in the decoder except for NotifyDownloadEnded.
Component: General → Video/Audio
Product: Fennec → Core
QA Contact: general → video.audio
Attached patch patch v0Splinter Review
Trivial crash fix.
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Attachment #513360 - Flags: review?(chris)
Attachment #513360 - Flags: review?(chris) → review+
Attachment #513360 - Flags: approval2.0?
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/07b8187bdc68
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing]
Status: RESOLVED → VERIFIED
Crash Signature: [@ nsCOMPtr_base::assign_assuming_AddRef | nsCOMPtr_base::assign_with_AddRef | nsHTMLMediaElement::Error]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: