Closed Bug 633620 Opened 13 years ago Closed 13 years ago

make nsIMsgDBView cell text scriptable

Categories

(Thunderbird :: Testing Infrastructure, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a3

People

(Reporter: Bienvenu, Assigned: Bienvenu)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch proposed fix (obsolete) — Splinter Review
nsITreeView.getCellText is not scriptable, which makes it hard/impossible to write xpcshell tests for some of the code in nsMsgDBView. For things like using the display name in the view, or the who column, we'd like to be able to do some simple tests.
Attached patch patch for reviewSplinter Review
the new method is only directly called from the view tests when they fail, but I think some tests will come along - I'll post to m.d.a.t once this lands.
Attachment #511842 - Attachment is obsolete: true
Attachment #511876 - Flags: review?(bugmail)
Comment on attachment 511876 [details] [diff] [review]
patch for review

But I worked so hard on that comment about the impossibility of what you are doing here!
Attachment #511876 - Flags: review?(bugmail) → review+
removing that comment was icing on the cake :-)

fixed on trunk - http://hg.mozilla.org/comm-central/rev/d6059bdc7053
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: