Closed Bug 633891 Opened 13 years ago Closed 13 years ago

nsGlobalWindow.cpp:6430: warning: unused variable 'cx' (remove unused variable)

Categories

(Core :: DOM: Core & HTML, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME
mozilla6

People

(Reporter: dholbert, Assigned: Ms2ger)

References

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

As noted in bug 621764 comment 22, that bug's checkin introduced this warning, from an unused variable:
> dom/base/nsGlobalWindow.cpp: In member function 'virtual void nsGlobalWindow::LeaveModalState(nsIDOMWindow*)':
> dom/base/nsGlobalWindow.cpp:6430: warning: unused variable 'cx'

Code:
> 6430   JSContext *cx = nsContentUtils::GetCurrentJSContext();

dolske tells me over email that this line was left over from an earlier patch incarnation, and it now wants to just be removed.
Blocks: 621764
Whiteboard: [build_warning] → [build_warning] [good first bug]
Attached patch Patch v1Splinter Review
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #518012 - Flags: review?(dolske)
Whiteboard: [build_warning] [good first bug] → [build_warning][needs review]
Comment on attachment 518012 [details] [diff] [review]
Patch v1

Oops. This is is already taken care of by the patch in bug 635888, which is just waiting for the tree to reopen.

r+ except for that. ;-)
Attachment #518012 - Flags: review?(dolske)
Depends on: 635888
Whiteboard: [build_warning][needs review] → [build_warning]
That works too. Thanks.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
Target Milestone: --- → mozilla6
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: