633913 - Add a pseudo-class to access indeterminate <progress> elements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

According to the specs, a progress element can be indeterminate. It might be interesting to let the authors access indeterminate progress elements given that they might want to style them differently.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 2

[Boris Zbarsky [:bzbarsky]]

For what it's worth, this is going to conflict with the various patches in bug 	313351, and bug 598833.  I can handle merging if this lands first, I guess, but just wanted to give you a heads-up.

Comment 3

[Boris Zbarsky [:bzbarsky]]

And wait.  Why do you need that AfterSetAttr gunk?

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to comment #3)
> And wait.  Why do you need that AfterSetAttr gunk?

Eh, I don't indeed: indeterminate state only depends on one attribute's value. This should make the merge issue smaller. Thanks for the noticing ;)

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Patch v1.1

Updated patch. Boris, you won the right to review it :)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 512147 [details] [diff] [review]
Patch v1.1

s/determinated/determined/ and looks good.  And yeah, now you're only conflicting with code I haven't written yet.  ;)

Comment 7

[Mounir Lamouri (:mounir)]

I wonder if we shouldn't use :-moz-indeterminate instead of :indeterminate here.

Comment 8

[Mounir Lamouri (:mounir)]

I've open a bug against HTML specs to have it specified:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=12210

Though, I should probably send an email somewhere to ask for a better specification of the indeterminate pseudo-class in CSS. I wonder if CSS3-UI couldn't simply override what Selectors say (it doesn't really say anything actually, the only specs is a Note....).

Comment 9

[Mounir Lamouri (:mounir)]

David, what is your feeling about comment 7? Boris is ok to not prefix it (according to our IRC conversation).

Comment 10

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/89d4c7fd4d0d

Comment 11

[Shawn Wilsher :sdwilsh]

Backed out in http://hg.mozilla.org/mozilla-central/rev/dd9ba28d2bd9 to resolve bug 655860.

Comment 12

[Mounir Lamouri (:mounir)]

The regression wasn't caused by these patches. Re-landed:
http://hg.mozilla.org/mozilla-central/rev/91fa0c94e6db

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm ok with unprefixed.

Comment 14

[Eric Shepherd [:sheppy]]

Documented:

https://developer.mozilla.org/En/CSS/:indeterminate
https://developer.mozilla.org/en/HTML/Element/progress

Also listed on Firefox 6 for developers.

Comment 15

[gnatko]

It looks like the :indeterminate pseudo-class is not being triggered on <progress> elements with no value.

Just try opening this page:

https://bulma.io/documentation/elements/progress/

in Firefox and then in Chrome.

In Chrome, you'll get animation for indeterminate progress bars.

In Firefox, the bars are just staying solid.

Also, when you click "inspect element" in Chrome, you'll see that the progress bar has the :indeterminate pseudo-class selected.

In Firefox, it doesn't.

Comment 16

[gnatko]

Oh, I'm sorry, it looks like :indeterminate is in deed being triggered in CSS, so probably the animation isn't done quite right. I'll check it out further.