633959 - Test failure in testTabRestoration.js | could not find element ID: history/localization

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aaron Train [:aaronmt]]

Module: testTabRestoration.js
Test: testTabRestoration
Error: could not find element ID: history/localization
Branch: default
Platform: Windows 7 (NT 6.1.7600)

http://hg.mozilla.org/qa/mozmill-tests/file/9d80953bf21c/firefox/testPrivateBrowsing/testTabRestoration.js#l98

http://mozmill-release.brasstacks.mozilla.com/#/general/failure?branch=4.0&platform=Windows%20NT&from=2011-02-07&to=2011-02-14&test=firefox%2FtestPrivateBrowsing%2FtestTabRestoration.js&func=testTabRestoration

Also see bug 633944

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default) [checked-in]

It seems like on slower systems, we need to a waitForElement, looks like waitForPageLoad is insufficient on its own on exit of PB mode (is this needed with local pages?). Not sure again why this is exposed now all of a sudden, as well, only Windows 7. Inserting a waitForElement is giving me passes on qa-horus

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 512288 [details] [diff] [review]
Patch v1 - (default) [checked-in]

Good catch! The underlying issue here is, that when leaving PB mode we load the pages from the bfcache. WaitForPageLoad cannot handle that at the moment. See the back and forward button test. Please land on all branches.

Comment 3

[Aaron Train [:aaronmt]]

Landed as:

default - http://hg.mozilla.org/qa/mozmill-tests/rev/fa1542a55fe1
1.9.2 - http://hg.mozilla.org/qa/mozmill-tests/rev/937d0ba8cc0b
1.9.1 - http://hg.mozilla.org/qa/mozmill-tests/rev/6d3ed5c83bfa

Comment 4

[Aaron Train [:aaronmt]]

Attachment: Patch v2 Follow-up correction - (default) [checked-in]

The new addition was placed in the wrong spot, but it was passing. It should really be in the spot after the exit of private browsing patch.

Comment 5

[Aaron Train [:aaronmt]]

Correction follow-up landed as:

http://hg.mozilla.org/qa/mozmill-tests/rev/cb9858a4e815
http://hg.mozilla.org/qa/mozmill-tests/rev/fff0b8361416
http://hg.mozilla.org/qa/mozmill-tests/rev/b24479a1b338