Closed Bug 634341 Opened 13 years ago Closed 13 years ago

Allow changing version status from Admin Disabled to something else without losing files

Categories

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jorgev, Assigned: jbalogh)

Details

(Keywords: regression, Whiteboard: [ReviewTeam])

When a file is Admin Disabled (normally a review rejection from the Editor Tools), it is moved to an inaccessible location, for security reasons (I suppose). Since we often change the status of a version to something else, we have run into the problem that we can't recover a rejected version because the file is missing.

So, we need the files to be moved back to their original location if the status of the version is changed from the admin tools to something other than disabled.
Target Milestone: 5.12.12 → 6.0.0
Priority: -- → P2
Signal: https://github.com/jbalogh/zamboni/commit/dab701f 
Shim: https://github.com/jbalogh/zamboni/commit/0b9c177 
Merge: https://github.com/jbalogh/zamboni/commit/53ff7ef 

jorgev: files won't get moved to the right place automatically if the status is changed in remora. We can't tell that a file status changed so we'd have to look through every file to make sure it's in the right place.

There's a temporary webpage at https://addons.allizom.org/z/en-US/admin/fix-disabled that will let you move a file back into the public realm. You give it a file id and it will move the file after confirming you picked the right file.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified on preview with this version:
https://addons.allizom.org/en-US/editors/review/124480
Status: RESOLVED → VERIFIED
Keywords: regression
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.