634609 - Fix GetNativeStackBaseImpl() on OpenBSD

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Landry Breuil (:gaston)]

User-Agent:       Midori/0.3 (X11; OpenBSD; U; fr-fr) WebKit/531.2+
Build Identifier: 

As of now, js fails to build on OpenBSD because either pthread_attr_get_np() or pthread_getattr_np() don't exist.

pthread_attr_init() + pthread_attr_getstack() won't work on OpenBSD, so we have to use pthread_stackseg_np() instead.

Reproducible: Always

Comment 1

[Landry Breuil (:gaston)]

Attachment: use pthread_stackseg_np() on OpenBSD

First proposition for a patch, minimizing the diff.
Ideally, the codepath for OpenBSD wouldn't need pthread_attr_t/pthread_attr_init/pthread_attr_destroy, so maybe it should be inside its own #ifdef block like macos code.
We might still need the last part of the function changing what's returned depending on JS_STACK_GROWTH_DIRECTION (though we don't build mozilla on hppa yet)

Comment 2

[Andreas Gal :gal]

Comment on attachment 512815 [details] [diff] [review]
use pthread_stackseg_np() on OpenBSD

Stealing. NPOTB, so no risk but even than approval might not come until after FF4 branched.

Comment 3

[Landry Breuil (:gaston)]

What's the procedure to get that commited now that there's r+ and a2.0+ ?
Should i do another patch putting the OpenBSD code inside its own #ifdef block for the sake of readability ?

Comment 4

[Andreas Gal :gal]

Just land it on the TM tree if you have commit access, or find someone who has.

Comment 5

[Joe Drew (not getting mail)]

Comment on attachment 512815 [details] [diff] [review]
use pthread_stackseg_np() on OpenBSD

Sorry, too late for 2.0.

Comment 6

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/tracemonkey/rev/489cdb307e41

Comment 7

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/489cdb307e41

Comment 8

[Landry Breuil (:gaston)]

Attachment: Include pthread_np.h on OpenBSD too for pthread_stackseg_np()

Duh!. pthread_np.h also needs to be included on OpenBSD for pthread_stackseg_np() to be defined... sorry i missed that one.

Comment 9

[Landry Breuil (:gaston)]

And reopening.

Comment 10

[Mounir Lamouri (:mounir)]

Pushed to cedar.

Comment 11

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/6588e8a0c8c5

(oups, I didn't meant to mark the bug as fixed before...)