Closed
Bug 634974
Opened 13 years ago
Closed 13 years ago
JavaScript strict warning: chrome://browser/content/tabview.js, line 3274: anonymous function does not always return a value
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: imphil, Assigned: imphil)
References
Details
Attachments
(1 file, 1 obsolete file)
1.07 KB,
patch
|
Details | Diff | Splinter Review |
I get the warning message: JavaScript strict warning: chrome://browser/content/tabview.js, line 3274: anonymous function does not always return a value A patch is attached. If I'm not mistaken the return is ignored anyway. I guess the idea was to exit from the each-loop, but the implementation of each in iQ seems to have no way to do this. (this was added in bug 600645)
Attachment #513175 -
Flags: review?(ian)
Comment 1•13 years ago
|
||
Comment on attachment 513175 [details] [diff] [review] patch v1 Good point! I've filed a follow-up: bug 635311
Attachment #513175 -
Flags: review?(ian) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 513175 [details] [diff] [review] patch v1 No real risk and no functional change, but it makes debug builds output less useless warnings and by that real problems easier to find.
Attachment #513175 -
Flags: approval2.0?
Updated•13 years ago
|
Assignee: nobody → mail
Status: NEW → ASSIGNED
Comment 3•13 years ago
|
||
Comment on attachment 513175 [details] [diff] [review] patch v1 a=beltzner
Attachment #513175 -
Flags: approval2.0? → approval2.0+
Comment 4•13 years ago
|
||
Attachment #513175 -
Attachment is obsolete: true
Updated•13 years ago
|
Keywords: checkin-needed
Comment 5•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/27ab44a83e3e
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•