635169 - cfx init should ignore hidden folders

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

A user on IRC was getting ready to set up a package in the local SDK. 

He ran bin\activate, and made a folder for his package, then changed to that directory and ran "cfx init".

It then complained about it not being an empty directory.

After creating the folder, the user had added it to a Subversion repository, so it had a ".svn" folder in it prior to running "cfx init".

If ignoring hidden folders is too much to do, maybe just whitelist folders like ".svn", ".hg" (and whatever git uses)?

Comment 1

[Brian Warner [:warner :bwarner]]

sounds like a good idea to me. Probably just ignore /^\./ -matching items. The change will go into python-lib/cuddlefish/__init__.py in the "initializer()" function, something like:

 existing = [fn for fn in os.listdir(path) if not fn.startswith(".")]
 if existing:
  print >>err, 'This command must be run in an empty directory.'
  return 1

Comment 2

[Brian Warner [:warner :bwarner]]

Attachment: patch, with tests

this patch should fix the problem, however let's keep bug 613604 (cfx init newdir) in mind as the preferred way to avoid this sort of thing

Comment 3

[Mihai Sucan [:msucan]]

Tested the patch. Works for me. Thanks Brian!

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Someone else fixed a special case of this with pull request 132 <https://github.com/mozilla/addon-sdk/pull/132>.

Brian: any reason not to get review on your patch at this point?

Comment 6

[Brian Warner [:warner :bwarner]]

nope, if it worked for Mihai, let's r? it.

Comment 7

[Brian Warner [:warner :bwarner]]

Comment on attachment 514209 [details] [diff] [review]
patch, with tests

Irakli, want to take a look at this?

Comment 8

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 514209 [details] [diff] [review]
patch, with tests

Looks good ;)

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Irakli: can you also check this in?

Comment 10

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Landed

Comment 11

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #10)
> Landed

Can you provide a link to the changeset?

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://github.com/mozilla/addon-sdk/commit/80b97b6b8e40e3bf8418247c6626c6b25058ce6a