635311 - iQ(".appTabIcon", this.$appTabTray).each() calls in groupitems.js should return early if possible

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Ian Gilman [:iangilman]]

There are 3 such loops, and they're all looking for a single entry. Once they've found that entry, they should return early. This is currently not possible, because iQ.each doesn't have a mechanism for early return. It should return early if the callback returns false which is what jQuery does:

http://api.jquery.com/each/

Note that in order to avoid JavaScript strict errors, the other code path in the loop has to return true (rather than nothing).

Comment 1

[Adam]

Attachment: Allows iQ.each to complete early if callback returns false, updates groupitems.js to do so.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 525149 [details] [diff] [review]
Allows iQ.each to complete early if callback returns false, updates groupitems.js to do so.

Looks good, although that "for (...) {}" looks a bit strange to me :)

Comment 3

[Ian Gilman [:iangilman]]

Comment on attachment 525149 [details] [diff] [review]
Allows iQ.each to complete early if callback returns false, updates groupitems.js to do so.

I agree the for(...) {} construct is a bit unusual, but it seems fine.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Hey Adam, it would be great to get this fix into the tree. Here is how to prepare the patch:

http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed

Thank you!

Comment 5

[Adam]

Attachment: Same patch, but prepared for pushing.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/e58b0ab494db