Closed Bug 635499 Opened 13 years ago Closed 12 years ago

Implement the max attribute for <input type='number'>

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: mounir, Assigned: mounir)

References

(Blocks 1 open bug)

Details

(Keywords: doc-bug-filed, html5)

Attachments

(2 files, 1 obsolete file)

Part 1 - Add the attribute
3.79 KB, patch
sicking
: review+
Details | Diff | Splinter Review
Part 2 - Constraint validation
17.27 KB, patch
sicking
: review+
Details | Diff | Splinter Review 
      No description provided.
Blocks: 635553
Blocks: 635554
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED

        Attachment #514043 -
        Flags: review?(jonas)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Part 2 - Constraint validation (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #514044 -
        Flags: review?(jonas)

    
  
Whiteboard: [needs review]

    
    

    
  


  
Use with double instead of float.

        Attachment #514044 -
        Attachment is obsolete: true

        Attachment #514044 -
        Flags: review?(jonas)

        Attachment #515625 -
        Flags: review?(jonas)

    
  
Depends on: 636750

    
  
Blocks: 563637

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/dab3703c3245
https://hg.mozilla.org/mozilla-central/rev/9d82cf442db1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [needs review]
Target Milestone: --- → mozilla16
Depends on: 802455

    
    

    
  
I know this is per the current spec, but I'm wondering why this IDL attribute is a DOMString rather than double.

    
    

    
  
(In reply to Jonathan Watt [:jwatt] from comment #5)
> I know this is per the current spec, but I'm wondering why this IDL
> attribute is a DOMString rather than double.

Because some input types (like time, date, datetime, week, month, etc.) will define something else than numbers in max (and min).

    
    

    
  
See bug 866457 for documentation.
Keywords: dev-doc-needed → doc-bug-filed

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: