635658 - ContentParent NS_IMPL_ISUPPORTS doesn't include nsIAccelerationListener

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Josh Matthews [:jdm]]

This seems incorrect to me.

Comment 1

[Alon Zakai (:azakai)]

It does seem odd to me too.

CCing the patch writer and reviewer.

Comment 2

[Doug Turner (:dougt)]

sounds like a bug.  we probably never QI only static cast to it.

Comment 3

[Josh Matthews [:jdm]]

Relevant code in the URL field.  This is an easy change of simply adding nsIAccelerationListener to the list of supported interfaces.

Comment 4

[Evan Shaw]

Attachment: Add nsIDeviceMotionListener to ContentParent's NS_IMPL_ISUPPORTS

Patch attached. nsIAccelerationListener was renamed to nsIDeviceMotionListener at some point after this bug was filed.

Comment 5

[Josh Matthews [:jdm]]

Comment on attachment 547639 [details] [diff] [review]
Add nsIDeviceMotionListener to ContentParent's NS_IMPL_ISUPPORTS

Nice detective work.  Would you mind putting together a new version that follows these guidelines to make checking it in easy: https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f ?

Comment 6

[Evan Shaw]

Hmmm, I thought I'd already done that. What's my patch lacking from those directions?

Comment 7

[Josh Matthews [:jdm]]

Oh, weird, I could have sworn is was missing. I'll push this with the r=jdm annotation.

Comment 8

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d06068f0fe1b

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/d06068f0fe1b