Closed Bug 635870 Opened 13 years ago Closed 5 years ago

window.showModalDialog download file bug

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Version:
1.9.2 Branch
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: dart13, Unassigned)

Details

Attachments

(1 file)

test case - fixed new line char in javascript string
701 bytes, application/octet-stream
Details 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13 ( .NET CLR 3.5.30729; .NET4.0E)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13 ( .NET CLR 3.5.30729; .NET4.0E)

There is a bug in modal dialog created by window.showModalDialog function.
When you try to download a file from link inside modal dialog, download dialog opens with all fields empty, and it is frozen. You can only close it on Close button in upper right corner of a window.

Reproducible: Always

Steps to Reproduce:
Steps to Reproduce:
1. Save the following file as Click.htm

<html xmlns="http://www.w3.org/1999/xhtml" >
<head>
    <title>Click Page</title>
</head>
<body>
<a href="test.ttt">test.ttt</a>
</body>
</html>

2. Save the file below as Dialog.htm

<html>
<body>
<script language="JavaScript">
function openWindow() {
   if (window.showModalDialog)
       {ret = window.showModalDialog("click.htm", '', 'dialogWidth:500px; dialogHeight:500px; scroll:no; status:no');}
   else
    alert("Upgrade Your Browser");
} 
</script>
<button onclick="openWindow();">Open Modal Dialog.</button>
</body>
</html>

3. Create text file 'test.ttt' with text "Firefox jumps over lazy dog!" inside the file.

4. Open the file dialog.htm and click the link 'test.ttt'.
Actual Results:  
File download dialog opens, but it is frozen. Buttons do not work, all fields like "which is a", "from", "save as" etc., are empty.

Expected Results:  
File download dialog opens asking you to save 'test.ttt' file to you local computer. 'OK' and 'Cancel' buttons provide default functionality.
Version: unspecified → 3.6 Branch
Reporter, the test case you provided is broken. On pressing the button nothing happens. Please attach this testcase as a .zip archive or make another testcase.
Thanks.
Product: Firefox → Toolkit
QA Contact: general → general
Version: 3.6 Branch → 1.9.2 Branch
(In reply to comment #1)
> Reporter, the test case you provided is broken. On pressing the button nothing
> happens. Please attach this testcase as a .zip archive or make another
> testcase.
> Thanks.

It is broken because of the javascript function openWindow()
this string should be in one line (without new line char)

'dialogWidth:500px; dialogHeight:500px; scroll:no; status:no'
Comment on attachment 514335 [details]
test case - fixed new line char in javascript string

>PK����ûW>Y¢¨û�����
>���dialog.htmmP=OÃ0Ý#å?¼$PÜ%_b`AL¨b4ñ5q1vä\H«ªÿǦKÖݽ»³ß{ÍHºKfD!»àËw+Ï[{§&:OØ2Âñ£øe~à°5`'4{e¤]ó.i�ê�ù ríúl¥ÐJh;¡¿CþËY¯UÿQzì²Ì_{%i¬îw»éTCP
#Ý0OÐj]ëS´Ì>ÍúþE=c$ 4:ÊÙë48!ÞìâàÁÙuFÇ:M®à-àQmpe!Ú´À«e¿^Tõ׬{ñ%)µ
ÛÛ;üf/ÿ±?M¾PK
>�����TjV>�n���������test.tttFirefox jumps over lazy dog!PK����jV>cVv������	���click.htm5A
>Â0D÷wøä�ù«Èo6^À+ÄöÛS+í@êíM¬ÍÃF"ÆDë^Kc"ð¾0çm>Ûiîùäãµ2üñ QCWúkÚ'ÝB¯Â[S0þsrºOõ@qÖGc ,�ã÷$~äzVÂPK�����ûW>Y¢¨û�����
>�������� �����dialog.htmPK�
>�����TjV>�nÈ�������������� �#��test.tttPK�����jV>cVv������	�������� �e��click.htmPK������¥�������
Attachment #514335 - Attachment mime type: text/html → application/octet-stream

The showModalDialog API was disabled in Firefox 56 and removed later on. As a result, I believe this bug is no longer present in (more) recent versions of Firefox. Please reopen and needinfo me if you think this bug is still relevant.

Bugmail filter: showModalDialogClosure.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: