636243 - Use JSOPTION_NO_SCRIPT_RVAL in nsDOMWorkerScriptLoader.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Michael Wu [:mwu]]

Attachment: Use JSOPTION_NO_SCRIPT_RVAL in nsDOMWorkerScriptLoader.cpp

The return value is never used so we can use JSOPTION_NO_SCRIPT_RVAL.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 514585 [details] [diff] [review]
Use JSOPTION_NO_SCRIPT_RVAL in nsDOMWorkerScriptLoader.cpp

Hm... I think you need to update nsDOMWorkerTimeout::ExpressionCallback::Run() as well.

Comment 2

[Michael Wu [:mwu]]

Attachment: Use JSOPTION_NO_SCRIPT_RVAL in nsDOMWorkerTimeout.cpp

Good catch. nsDOMWorkerTimeout.cpp compiles and executes the code in one step so it's easier here. These patches remain independent of each other, but we might as well fix all the dom worker stuff in one bug.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 514606 [details] [diff] [review]
Use JSOPTION_NO_SCRIPT_RVAL in nsDOMWorkerTimeout.cpp

Looks like this is the wrong patch.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 514585 [details] [diff] [review]
Use JSOPTION_NO_SCRIPT_RVAL in nsDOMWorkerScriptLoader.cpp

After talking with one of the JS devs I think we should add JSOPTION_NO_SCRIPT_RVAL around the call to JS_Execute here too.

Comment 5

[Michael Wu [:mwu]]

Attachment: Use JSOPTION_NO_SCRIPT_RVAL in nsDOMWorkerTimeout.cpp (right patch)

Opps.

Comment 6

[Michael Wu [:mwu]]

(In reply to comment #4)
> Comment on attachment 514585 [details] [diff] [review]
> Use JSOPTION_NO_SCRIPT_RVAL in nsDOMWorkerScriptLoader.cpp
> 
> After talking with one of the JS devs I think we should add
> JSOPTION_NO_SCRIPT_RVAL around the call to JS_Execute here too.

Counter example:
http://hg.mozilla.org/mozilla-central/file/8f8f80356db4/js/src/shell/js.cpp#l448

Comment 7

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/dfcd2378bd75
http://hg.mozilla.org/mozilla-central/rev/e9b3541f85d1