636245 - Device Manager window size is hardcoded in XUL

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Marek Stępień [:marcoos, inactive]]

http://mxr.mozilla.org/mozilla-central/source/security/manager/pki/resources/content/device_manager.xul#53

style="width: 52em; height: 32em;"

This should be replaced with an entity and made localizable.

Comment 1

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch

This moves the width and height CSS properties to &devmgr.style;.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 580192 [details] [diff] [review]
Patch

Review of attachment 580192 [details] [diff] [review]:
-----------------------------------------------------------------

Looks OK to me, but Kai should do the real review here.

Comment 3

[Marek Stępień [:marcoos, inactive]]

Kai, can you review this?

Comment 4

[Kai Engert (:KaiE:)]

Comment on attachment 580192 [details] [diff] [review]
Patch

r=kaie

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Landing without Try results since this doesn't functionally change anything.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e79bf6f458f7

Marek, please make sure that future patches you attach include the necessary hg metadata so that they're more checkin-ready. Thanks!
https://developer.mozilla.org/en-US/docs/Creating_a_patch_that_can_be_checked_in

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e79bf6f458f7