636258 - Filter out inactive and admin-disabled add-ons from Compatibility Report

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect, P2)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Patch V1. Filters out disabled and inactive add-ons

Our compatibility numbers would look a little better if we filter out add-ons that are no longer offered on our site and in most cases are abandoned. With Firefox 4 approaching, I think it would be very useful to have a more realistic view of our work migrating developers.

This is a patch for the compatibility report generator that filters out add-ons that have been marked as inactive by the developer, or admin-disabled by us.

On a separate note: I'm not too well-versed in SQL, but it would appear that that query doesn't count add-ons that don't have an en-US translation. Shouldn't

translations.locale = 'en-US'

be 

translations.locale = addons.default_locale

or something similar?

Comment 1

[Wil Clouser [:clouserw]]

Comment on attachment 514594 [details] [diff] [review]
Patch V1. Filters out disabled and inactive add-ons

Looks fine to me.  I don't know about the en-US thing - maybe the compat reporter was originally en-US only?

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

I think the intended purpose of that condition is to get the en-US name of the add-on, but it's also (unintentionally, I think) discarding any add-ons that don't have en-US localizations. I assume there are at least a few of those in the top usage list.

fligtar, do you know?

Comment 3

[Justin Scott [:fligtar]]

yes, it should be default locale.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

Attachment: Patch V2. With fixed locale bug

OK, I'm lagniapping this bug then.

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 514663 [details] [diff] [review]
Patch V2. With fixed locale bug

I can r+ the code, but I didn't check that the output corresponds to what you want.

Comment 6

[Justin Scott [:fligtar]]

(In reply to comment #4)
> OK, I'm lagniapping this bug then.

woah woah woah. since when do you use Louisiana French?

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

Fixed, r83157.
There's still about a week to test if the changes are effective.

(In reply to comment #6)
> woah woah woah. since when do you use Louisiana French?

That word has haunted me for a while and I /needed/ to use it in a sentence.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

I tested on allizom, but the page is giving me 0 add-ons for the Compatibility Report:
https://addons.allizom.org/en-US/firefox/compatibility

I'm not sure if this happened before this patch, but it's possible. I tested the modified query directly against the DB, and I did get correct results, so there doesn't appear to be a syntax or logic error there.

Is there anything different in allizom that would make this report fail?

Comment 9

[Wil Clouser [:clouserw]]

(In reply to comment #8)
> I tested on allizom, but the page is giving me 0 add-ons for the Compatibility
> Report:
> https://addons.allizom.org/en-US/firefox/compatibility
> 
> I'm not sure if this happened before this patch, but it's possible. I tested
> the modified query directly against the DB, and I did get correct results, so
> there doesn't appear to be a syntax or logic error there.
> 
> Is there anything different in allizom that would make this report fail?

The numbers are generated off a cron job and stored in a file on the FS, afaik.  I don't know how often it runs.

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

It's working now: https://addons.allizom.org/en-US/firefox/compatibility

The modified query now produces 794 add-ons instead of 776 due to the popular add-ons that were taken out due to being disabled.

I can confirm that some popular disabled add-ons are no longer on the list, and some popular localized add-ons (dictionaries, mostly) now appear. The new percentages are pretty much the same, with -1% difference.

One bug I noticed is that some names can appear with question marks instead of special characters, like:
https://addons.allizom.org/en-US/firefox/addon/%E6%96%B0%E5%90%8C%E6%96%87%E5%A0%82-new-tong-wen-tang/
I don't think it's important to address this now. It can be fixed in the migration to Zamboni.

Verified.

Comment 11

[Wil Clouser [:clouserw]]

Question marks?  I think that's your fonts.  It looks fine to me.

Comment 12

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to comment #11)
> Question marks?  I think that's your fonts.  It looks fine to me.

This is in the compatibility page, in the detailed report that shows the full list of add-ons. Search for ???? and you'll see a link to the add-on I just pointed out.

Comment 13

[Wil Clouser [:clouserw]]

Got it, yeah, we'll fix that up.