Closed
Bug 636538
Opened 13 years ago
Closed 13 years ago
Remove xul: prefixes in createElementNS calls in HUDService.jsm
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 8
People
(Reporter: rcampbell, Assigned: rcampbell)
References
Details
(Whiteboard: [good first bug] [cleanup] [console-1])
Attachments
(1 file)
|
6.70 KB,
patch
|
ddahl
:
review+
|
Details | Diff | Splinter Review |
There are between 11 and 12 occurrences (depending on which patches are installed) of createElementNS(XUL_NS, "xul:tagname") in HUDService.jsm. The xul: prefix is at best a no-op since we're specifying the namespace. We should remove them based on Dao's comment in: https://bugzilla.mozilla.org/show_bug.cgi?id=611795#c54
|
||
Updated•13 years ago
|
Whiteboard: [cleanup] → [cleanup] [console-1]
|
||
Updated•13 years ago
|
Whiteboard: [cleanup] [console-1] → [good first bug] [cleanup] [console-1]
|
Assignee | |
Comment 1•13 years ago
|
||
taking this as a follow-up to bug 662807.
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #548537 -
Flags: review?(ddahl)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 548537 [details] [diff] [review] [in-fx-team] remove xul: Awesome. More of my clutter is being removed!
Attachment #548537 -
Flags: review?(ddahl) → review+
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [good first bug] [cleanup] [console-1] → [good first bug] [cleanup] [console-1][fixed-in-devtools]
|
|
Assignee | |
Updated•13 years ago
|
Attachment #548537 -
Attachment description: remove xul: → [in-fx-team] remove xul:
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [good first bug] [cleanup] [console-1][fixed-in-devtools] → [good first bug] [cleanup] [console-1][fixed-in-fx-team]
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a2690a2d6270
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [good first bug] [cleanup] [console-1][fixed-in-fx-team] → [good first bug] [cleanup] [console-1]
Target Milestone: --- → Firefox 8
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•