Closed Bug 636744 Opened 13 years ago Closed 13 years ago

InlineWriteBarrierGuardedTrap need to assert more aggressively that container is a GCObject

Categories

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)

Product:
Tamarin Graveyard
Component:
Garbage Collection (mmGC)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Q3 11 - Serrano

People

(Reporter: treilly, Assigned: pnkfelix)

Details

(Whiteboard: fixed-in-tr)

Attachments

(1 file)

unbury barrier asserts.
1.25 KB, patch
treilly
: review+
lhansen
: superreview+
Details | Diff | Splinter Review 
Having the asserts buried under BarrierActive() isn't good.
(swipe)

This should be easy to implement; the "hard" part is doing the appropriate sandbox builds (including player land).

(I'll unassign myself if I discover that I shouldn't have put sarcasm-quotes around the word "hard" above. :)
Assignee: nobody → fklockii
Priority: -- → P3
Target Milestone: --- → Q3 11 - Serrano
Priority: P3 → P4
Fix it or move it to Anza.
Priority: P4 → P3
Comment on attachment 516607 [details] [diff] [review]
unbury barrier asserts.

This looks like it will survive ATS runs.  Lets get it in there!
Attachment #516607 - Flags: superreview?(lhansen)
Attachment #516607 - Flags: review?(treilly)
Attachment #516607 - Flags: review?(treilly) → review+
Attachment #516607 - Flags: superreview?(lhansen) → superreview+
changeset: 6341:60ea629f807a
user:      Felix S Klock II <fklockii@adobe.com>
summary:   Bug 636744: unbury barrier asserts (r=treilly, sr=lhansen).

http://hg.mozilla.org/tamarin-redux/rev/60ea629f807a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
(whoops, still need to push to tr-serrano)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: fixed-in-tr
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: