Closed Bug 63686 Opened 24 years ago Closed 24 years ago

npnul32.rc should not depend on afxres.h

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(3 files)

remove dependency on afxres.h
526 bytes, patch
Details | Diff | Splinter Review
corrected patch.
526 bytes, patch
Details | Diff | Splinter Review
clean out useless apstudio entries
2.24 KB, patch
Details | Diff | Splinter Review 
Removing the dependency makes it easier for mozilla to build w/o MFC which we 
are trying to do.

    
    

    
  
av: please review this.
Assignee: av → timeless
Keywords: approval, 
          
            patch, 
          
            review

    
    

    
  
Right, see no reason to depend on MFC. r=av

    
    

    
  

      
      
      
      

        Attached patch
          
          
        corrected patch.
        — 
          — Splinter Review
      

    


  

    
    

    
  
Someone was cheating and using MFC to include the defines from winresrc.h

This version builds.

    
    

    
  
r=leaf, i'm not sure if this counts as being in the ``windows build system,''
though, since it's a non-makefile.win/config file. Should still get an sr.

    
    

    
  
sr=syd

    
    

    
  
fix checked in, sr=syd.
fwiw, the include chain is mfc\afxres.h=>mfc\winres.h=>winresrc.h
dialog constants are defined in that last file.
Status: NEW → RESOLVED
Closed: 24 years ago

    
    

    
  
something about bugzilla.
Status: RESOLVED → REOPENED

    
    

    
  
Resolving _FIXED_
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED

    
    

    
  


  

    
    

    
  
verified fix was checked in 1.4 version.
Status: RESOLVED → VERIFIED

    
  
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: