637018 - White line above content in glass w/maximized window, navigation bar and favorites bar disabled

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Peter Henkel [:Terepin]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b13pre) Gecko/20110226 Firefox/4.0b13pre
Build Identifier: 

It's hard for me to describe what exactly is happening, although I'm sure it was happening before. It occurs either after landing new Aero border calculating or after after baking it out. Jimm will know more.

Reproducible: Always

Comment 1

[Peter Henkel [:Terepin]]

Attachment: Maximized - not correct

Comment 2

[Peter Henkel [:Terepin]]

Attachment: Unmaximized - correct

Upps, I forgot to attach screenshots. My bad.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Isn't this just  bug 572160?

Comment 4

[Peter Henkel [:Terepin]]

Nope, the issue here is that white line in page's content area.

Comment 5

[imradyurrad]

(In reply to comment #4)
> Nope, the issue here is that white line in page's content area.

Change the title then.

Comment 6

[[not reading bugmail]]

I thought that was fixed by a backout bug once already.

Comment 7

[Jim Mathies [:jimm]]

(In reply to comment #6)
> I thought that was fixed by a backout bug once already.

That was a different problem that was fixed by a back out. This has something to do with all the toolbars being disabled.

Comment 8

[Jim Mathies [:jimm]]

Looks like it may be tied to the tabs in titlebar changes. A regression range would help.

Comment 9

[Edo Karabas]

Looks fine here: http://img18.imageshack.us/img18/5592/59235467.jpg

Comment 10

[Peter Henkel [:Terepin]]

(In reply to comment #8)
> Looks like it may be tied to the tabs in titlebar changes. A regression range
> would help.

I would love to help you, but these issue was introduced with either new border calculation, or after backing it out. Unfortunately I wasn't aware of this bugs so I have no idea where to look.

Comment 11

[:Felipe Gomes (needinfo for replies!)]

Not a widget bug, just a theme oddity. That line is this element: http://hg.mozilla.org/mozilla-central/annotate/e633e7a4af4b/browser/themes/winstripe/browser/browser.css#l75

For some reason it ends up positioned 1px lower on a maximized window, maybe on purpose?

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to comment #11)
> For some reason it ends up positioned 1px lower on a maximized window, maybe on
> purpose?

Random uneducated guess: There's a gap between the top edge of the tabs and the edge of the window when the tabs are up in the titlebar when the window is maximized, maybe that's pushing that element down too far?

Comment 13

[Jim Mathies [:jimm]]

This should be fixed in nightlies starting tomorrow. Although in testing be wary of bug 656946.

Comment 14

[Peter Henkel [:Terepin]]

Jim, can you mark this as RESOLVED FIXED? It was fixed some time ago (in UX branch at least).