Closed
Bug 637234
Opened 13 years ago
Closed 13 years ago
timepicker element ignores locale specific configuration, e.g. 24h clocks
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: grbradt, Assigned: enndeakin)
Details
(Keywords: regression)
Attachments
(2 files)
2.33 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
2.42 KB,
patch
|
nmaier
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b13pre) Gecko/20110227 Firefox/4.0b13pre Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b13pre) Gecko/20110227 Firefox/4.0b13pre In Firefox 3, timepicker would use the time format (12 or 24 hour) as defined by OS long time. In Firefox 4, it always uses 12 hour time. Reproducible: Always
Updated•13 years ago
|
QA Contact: xptoolkit.widgets → xptoolkit.xul
Comment 1•13 years ago
|
||
The is24HourClock field is specified as readonly: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/datetimepicker.xml#249 But the field is only initialized in |_init|, which then fails: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/widgets/datetimepicker.xml#508 XBL seems to have implemented readonly fields in moz-2, hence the regression. This regression is not limited to 24h clocks, but all locale specific runtime configuration (see workaround below). CC'ing Neil, as he wrote the code it seems. As a work-around, one might re-bind <timepicker> against the following binding that strips away the readonly stuff: <binding id="timepicker" extends="chrome://global/content/bindings/datetimepicker.xml#timepicker"> <implementation> <field name="is24HourClock">false</field> <field name="hourLeadingZero">false</field> <field name="minuteLeadingZero">true</field> <field name="secondLeadingZero">true</field> <field name="amIndicator">"AM"</field> <field name="pmIndicator">"PM"</field> </implementation> </binding>
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
OS: Windows 7 → All
Hardware: x86 → All
Summary: Minefield: timepicker element always uses 12 hour time, even in 24 hour time locales → timepicker element ignores locale specific configuration, e.g. 24h clocks
Version: unspecified → 2.0 Branch
Assignee | ||
Comment 2•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #536044 -
Flags: review? → review?(neil)
Comment 3•13 years ago
|
||
(In reply to comment #1) > XBL seems to have implemented readonly fields in moz-2, hence the regression. That would have been bug 542406.
Updated•13 years ago
|
Attachment #536044 -
Flags: review?(neil) → review+
Comment 4•13 years ago
|
||
Comment on attachment 536044 [details] [diff] [review] Suppose we should remove the readonly flag for now Review of attachment 536044 [details] [diff] [review]: ----------------------------------------------------------------- You didn't ask me for review, but r- from me anyway ;) ::: toolkit/content/tests/widgets/test_timepicker.xul @@ +43,5 @@ > tp.value = testtag_gettimestring(thour, tminute, tsecond); > testtag_comparetime(tp, testid + "set value", thour, tminute, tsecond); > > + var fdt = new Date(2000,0,1,16,7,9).toLocaleFormat("%X"); > + is(tp.is24HourClock, Number(fdt) > 12, "is24HourClock"); This test is broken, and will fail on an is24HourClock machine, and only by accident succeed otherwise. Number("16:07:09") is NaN
Assignee | ||
Comment 5•13 years ago
|
||
OK thanks! I guess I should be more careful with copying text.
Attachment #536101 -
Flags: review?(MaierMan)
Updated•13 years ago
|
Attachment #536101 -
Flags: review?(MaierMan) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/50103c9579b0
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Not clear to me: Is there a fix? Using TB 11.0.1 doesn't work with <timepicker id="timePickerCurrent" hideseconds="true" is24HourClock="false" /> to see 11:05pm instead of 23:05.
Comment 8•6 years ago
|
||
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in
before you can comment on or make changes to this bug.
Description
•