637251 - fileField can display non-ascii characters incorrectly (In Thunderbird, the file name is garbled in Photo tab of a contact)

Status: RESOLVED INACTIVE

(Toolkit :: UI Widgets, defect)

Description

[Boying Lu]

locale: zh-CN.UTF-8

Steps to reproduce:

1)Launch #thunderbird
2)Create a New Contact from File->New->Address Book Contact
3)Input the contact details and in Photo tab select a localized image file in "On this computer" field

Result: Localized image filename is garbled in this field

Comment 1

[Boying Lu]

Attachment: set filefield label to path name explicitly

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 515570 [details] [diff] [review]
set filefield label to path name explicitly

Whilst this works around the issue, I'm not convinced it is the correct fix. The really issue appears to be here:

http://hg.mozilla.org/mozilla-central/annotate/1240004b90e6/toolkit/content/widgets/filefield.xml#l71

nsIURL.fileName may contain escaped characters. So if we don't want to display escaped characters I think that is the place where it looks like we should fix it.

Fixing the core issue would also fix the case where we're re-opening the dialog, which this patch currently misses.

Comment 3

[[e-mail]]

Looks like this is a bug in the <filefield> implementation - it gets the name by converting the file to a URL (!) which encodes non-ascii characters.

Comment 4

[[e-mail]]

Looks like the code did this ever since Ben's first check in 6 years ago.

Comment 5

[Boying Lu]

Attachment: fix in filefield

Comment 6

[[e-mail]]

Comment on attachment 519343 [details] [diff] [review]
fix in filefield

>+          let lf = aFile.QueryInterface(Components.interfaces.nsILocalFile);
You don't need nsILocalFile; path is an attribute on nsIFile. Also newFileURI will already fail if aFile isn't an nsIFile, so you don't need both cases.

>+            return lf.path;
Did you mean the whole path? I would have thought the leafName would suffice (leafName is also an attribute on nsIFile of course).

Comment 7

[Boying Lu]

Attachment: using nsIFile.leafName

Comment 8

[Mark Banner (:standard8)]

As this is really a bug in toolkit, moving to the toolkit product.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mstriemer, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 10

[Mark Striemer [:mstriemer]]

I can't find the file that was patched here.