637485 - httpserver is a module level variable and should be encapsulated

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

For some reasons we declare the server outside of the collector class
and then manipulate this module level variable inside the collector class:

https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/frame.js#L305

Unless there is a reason to keep it external, it should be used
entirely within the collector class.  If there is a reason to keep it
external, it should be a parameter to Collector.  Currently it lives
at module level but is strangely manipulated (e.g. overwritten) within Collector

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's why I have filed bug 554197 a while back to get rid of all those manipulation, also of the httpd.js code itself.

Comment 2

[Jeff Hammel]

this is fixed with the landing of bug 638989