637881 - Remove 'Reflow on Zoom' preference for Fennec 4

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We are removing this for Fennec 4. The code stays, but the visible preference goes.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Removes the preference, leaves the rest.

An add-on can re-enable the behavior.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

If we remove the pref we should remove the string (&reflowZoom.title;) right?

Comment 3

[Matt Brubeck (:mbrubeck)]

Comment on attachment 516044 [details] [diff] [review]
patch

Code change is fine, though I honestly think we are better off shipping this than not, even in its current state.

(In reply to comment #2)
> If we remove the pref we should remove the string (&reflowZoom.title;) right?

If it's already translated, maybe we should leave it in place for use by the add-on that re-enables this?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

> (In reply to comment #2)
> > If we remove the pref we should remove the string (&reflowZoom.title;) right?
> 
> If it's already translated, maybe we should leave it in place for use by the
> add-on that re-enables this?

Exactly

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/c779e14f9594

Comment 6

[Ioana Chiorean]

verified fixed on build id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110302
Firefox/4.0b13pre Fennec /4.0b6pre

Comment 7

[Matt Brubeck (:mbrubeck)]

This change was reverted in bug 640069.