63832 - Makefile.in files have gmake hard coded

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Frank Belew]

assuming gnu make is understandable, assuming it is called gmake is not
especially when one may have to pass special flags to make on their arch


I'm attaching a patch to change all references to gmake (except #! lines) to use
$(MAKE) instead, since its the Right Way(tm)

Have a nice day :)

Comment 1

[Frank Belew]

Attachment: Patch to fix nss/Makefile and psm/Makefile.in

Comment 2

[Brian Ryner (not reading)]

r=bryner

Comment 3

[Wan-Teh Chang]

I checked in Myth's patch to mozilla/security/nss/Makefile.
I also took the opportunity to delete the dead code in that
makefile.  I only checked in the patch on the main trunk of
NSS (which is not used when building PSM) because the affected
part of the makefile is only used when we do our NSS binary
releases at iPlanet.
/cvsroot/mozilla/security/nss/Makefile, revision 1.13

I also fixed another makefile in NSS with this problem:
/cvsroot/mozilla/security/nss/lib/fortcrypt/Makefile, revision 1.4

I will look at the PSM makefiles tomorrow as David is going on
sabbatical next week so he is now allowed to check in now :-)

Comment 4

[Stephan Niemz]

*** Bug 65446 has been marked as a duplicate of this bug. ***

Comment 5

[Stephan Niemz]

I think you need to check in the changes to psm/Makefile.in, too.
At least I had to apply them to make Mozilla build here.

Comment 6

[Wan-Teh Chang]

I noticed that Javi has checked in the patch for psm/Makefile.in,
after I went under psm and fixed all the references to gmake.  I'm
going to attach the patch anyway that fixes the other (apparently
unused) makefiles under psm.

Comment 7

[Wan-Teh Chang]

Attachment: Patch to fix remaining references to gmake under psm.

Comment 8

[Wan-Teh Chang]

Javi, please review my patch.  Let me know if you
still want to have the remaining references to
gmake under psm fixed, or just tell me "don't
bother".

Comment 9

[Stephan Niemz]

I think this blocks bug 60912 because normally there isn't a "gmake" binary
or symlink on Linux, so adding dependency.

Comment 10

[Javier Delgadillo]

r=javi,

Go ahead and check this in when the mozilla tree opens.  It's pretty 
straightforward. 

Comment 11

[Wan-Teh Chang]

I checked in my second patch to fix the remaining hardcoded
gmake's in PSM makefiles.