638790 - [autoconfig] Don't show error after leaving dialog without entering anything

Status: NEW

(Thunderbird :: Account Manager, defect)

Description

[Ben Bucksch (:BenB)]

Reproduction:
1. TB menu: File | New | Mailaccount...
2. Don't enter anything
   (e.g. because you need to look up your email address)
3. Go to other app
4. Go back to our dialog

Actual result:
The realname field shows a yellow error text "Please enter your name."

Expected result:
No error.
We may show the enter once the user advanced further into the dialog, e.g. entered a proper email address.

Comment 1

[Ben Bucksch (:BenB)]

We could show the realname error only once the user entered a proper email address. Therefore, we won't show the realname error while the form is completely empty (that's pointless and the problem here). If he enters no realname, but something as email address and the email addr is invalid, we'll show the email address error only. If the email address is correct and the realname still empty, we'll show the realname error. (All this time, the Continue button stays disabled, until all the errors are corrected.)

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Why not only show the realname if the user entered anything in the email address?  That way the user will see all the things they have to fix at once, instead of having them run into thing after thing after thing, and not know when it ends…

Comment 3

[Ben Bucksch (:BenB)]

> We could show the realname error only once the user entered a proper email
> address.

FYI: I implemented that in bug 549045 (UI-review there), because it was easy enough:
https://hg.mozilla.org/users/mozilla.BenB_bucksch.org/tb-autoconfig-ui-1/rev/6b3e237ce651

> That way the user will see all the things they have to fix at once,
> instead of having them run into thing after thing after thing

That's precisely the question... I thought it's better to show one error after the other, but that's purely a matter of opinion. It's also a one-line code change now:
- } else if (this.validateEmailMinimally(this._email)) {
+ } else if (this._email) {