Closed
Bug 639589
Opened 13 years ago
Closed 12 years ago
Use js-ctypes extensions for more efficient buffer filling
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: rnewman, Assigned: rnewman)
References
(Depends on 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
4.78 KB,
patch
|
Details | Diff | Splinter Review |
(Follow-on from Bug 638297.) It takes approximately 1msec to perform a test run of byteCompressInts in JS. It takes 0.06msec to allocate a new buffer, with the buffer filling being performed inside js-ctypes' C++ code. The downside of that is that a first sync allocates 700MB of garbage buffers. We would like the best of both worlds. This bug tracks a possible extension of js-ctypes which gets us down to 0.01msec for the run, without the allocations. I fully expect a lot of negative review comments; consider this a straw man!
Assignee | ||
Comment 1•13 years ago
|
||
This adds ArrayType::ByteCompress. Note that this is similar to, but much more specific than, the WriteString proposal in https://wiki.mozilla.org/Jsctypes/api .
Assignee | ||
Comment 2•13 years ago
|
||
N.B., there is some comment stubbetry in attachment 517505 [details] [diff] [review]; we at some point want to push more operations down, so I actually started with readBytes. Please ignore.
Assignee | ||
Comment 3•13 years ago
|
||
Rejigging this bug to depend on one in Core :: js-ctypes.
Summary: Extend js-ctypes for more efficient buffer filling → Use js-ctypes extensions for more efficient buffer filling
Assignee | ||
Updated•13 years ago
|
Attachment #517505 -
Attachment is obsolete: true
Assignee | ||
Comment 4•12 years ago
|
||
Dead-end.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•