Closed
Bug 639730
Opened 13 years ago
Closed 13 years ago
Please check menuItem.tab instead of menuItem.hasAttribute("keepme")
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 6
People
(Reporter: tabutils+bugzilla, Assigned: fryn)
References
Details
(Whiteboard: [fixed by bug 653655])
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b13pre) Gecko/20110303 Firefox/4.0b13pre http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#3705 3705 <handler event="popuphidden"> 3706 <![CDATA[ 3707 // clear out the menu popup and remove the listeners 3708 for (let i = this.childNodes.length - 1; i > 0; i--) { 3709 let menuItem = this.childNodes[i]; 3710 if (!menuItem.hasAttribute("keepme")) { 3711 menuItem.removeEventListener("command", this, false); 3712 menuItem.tab.mCorrespondingMenuitem = null; 3713 this.removeChild(menuItem); 3714 } 3715 } 3716 var tabcontainer = gBrowser.tabContainer; 3717 tabcontainer.mTabstrip.removeEventListener("scroll", this, false); 3718 tabcontainer.removeEventListener("TabOpen", this, false); 3719 tabcontainer.removeEventListener("TabAttrModified", this, false); 3720 tabcontainer.removeEventListener("TabClose", this, false); 3721 ]]></handler> Please remove the "keepme" attribute. It's unnecessary. Check menuItem.tab instead. Reproducible: Always
Updated•13 years ago
|
Severity: normal → trivial
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: P1 → --
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → fryn
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 1•13 years ago
|
||
Verified fixed by check-in.
Status: RESOLVED → VERIFIED
Flags: in-litmus-
Whiteboard: [fixed by bug 653655]
Target Milestone: --- → Firefox 6
You need to log in
before you can comment on or make changes to this bug.
Description
•