639849 - Remove nsIDOM3Document

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Looks like this needs bug 589894 to apply.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 517750 [details] [diff] [review]
Patch v1

>+++ b/dom/base/nsGlobalWindow.cpp
>+    nsCOMPtr<nsIDOMDocument> domdoc = do_QueryInterface(mDoc);
>+    if (domdoc)
>+        domdoc->GetDocumentURI(documentURI);

Just do:

  mDocument->GetDocumentURI(documentURI);

>+    nsCOMPtr<nsIDOMDocument> domdoc = do_QueryInterface(mDoc);
>+    if (domdoc)
>+        domdoc->GetDocumentURI(documentURI);

Likewise.

r=me with those nits.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch for checkin

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/projects/cedar/rev/f9e83c80242c

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f9e83c80242c

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Shouldn't this have rev'd IIDs on all interfaces that derive from nsIDOMDocument?  There are a bunch of crashes that seem to have showed up as a result of this, related to some Norton stuff and possibly other things -- and it's possible that it's not even really their fault.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: rev more IIDs

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 522912 [details] [diff] [review]
rev more IIDs

r=me

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/4524bb785a79

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Looks so far like it did fix the crashes.  Crash queries with date ranges:

https://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox:4.2a1pre&version=Firefox:4.0b13pre&query_search=signature&query_type=exact&query=&date=04%2F10%2F2011%2000%3A00%3A00&range_value=30&range_unit=days&hang_type=crash&process_type=browser&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=nsHTMLDocument%3A%3AGetElementsByName%28nsAString_internal%20const%26%2C%20nsIDOMNodeList**%29

https://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox:4.2a1pre&version=Firefox:4.0b13pre&query_search=signature&query_type=exact&query=&date=04%2F10%2F2011%2000%3A00%3A00&range_value=30&range_unit=days&hang_type=crash&process_type=browser&plugin_field=&plugin_query_type=&plugin_query=&do_query=1&admin=&signature=nsDocument%3A%3AAdoptNode%28nsIDOMNode*%2C%20nsIDOMNode**%29