Closed Bug 639900 Opened 13 years ago Closed 13 years ago

Attachment actions that include a renaming step should not notify the user

Categories

(addons.mozilla.org Graveyard :: Add-on Builder, defect, P2)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Builder
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Builder 0.9

People

(Reporter: ashah, Assigned: zalun)

Details

When I upload an attachment inside a folder, it says folder/attachment_X added. but then, the next moment it says folder/attachment_X renamed.

After talking to daniel, we should not show the second message to the user. There should only be one message when we upload an attachment
I'm assuming the callback success response from the back-end is triggering this roar, so I added Piotr to the assignee, feel free to change it if you'd like.
Assignee: nobody → zaloon
All actions that the user initiates should bundle all required, included actions together in one request. For example, when I add and attachment, it should not rename on callback or as a separate step, it should happen all in one http request loop.
Severity: normal → blocker
OS: Mac OS X → All
Priority: -- → P1
Summary: Dont show attachment renamed message after uploading an attachment to a folder in an addon → Attachment actions that include a renaming step should not notify the user
Target Milestone: --- → Builder 0.9
Hardware: x86 → All
Severity: blocker → normal
Priority: P1 → P2
Uploading the attachment is not a usual upload - it allows to multiple files being uploaded (at least it was designed like that). Because of that, Django extracts files from "raw data" send to back-end.

https://github.com/mozilla/FlightDeck/commit/932721a6f582d23e2fbbed907ee14ed3d0991172

fixed by silencing the rename function
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified on:
https://builder-addons-next.allizom.org
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.