640129 - Report type contains NotImplementedError as value

Status: VERIFIED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the latest changeset on master the report_type entry in the report written out by Mozmill contains the following value: "report_type": "NotImplementedError"

Looks like something broke in the last couple of weeks probably due to the refactoring.

Comment 1

[Jeff Hammel]

Attachment: remove report_type entirely, deprecated

Comment 2

[Heather Arthur [:harth]]

Comment on attachment 519558 [details] [diff] [review]
remove report_type entirely, deprecated

no more MozmillRestart, so this make sense.

Comment 3

[Jeff Hammel]

yeah;  when we gained the ability to run restart and non-restart tests in the same (python) process, report_type no longer made since, which is when I returned the string NotImplementedError (note: string, not the exception of the same name). I forgot the reason -- probably because a quick consensus could not be reached on what (if anything).  This is just cleanup from that which makes more sense as the line between restart and non-restart tests becomes increasingly blurred.

Comment 4

[Jeff Hammel]

pushed to master: https://github.com/mozautomation/mozmill/commit/b19629cb9725d454ddc5c48e5e0f22bc574d77d7

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That change will need a fix in our dashboard code, so we don't fail on a non-existing report_type field. Otherwise I'm fine with the removal.

Comment 6

[Jeff Hammel]

If it helps to return a stub value, we can, but there's no longer a distinction between restart and non-restart runs as.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

If you could simply include "mozmill-test" as report type it would be great.

Comment 8

[Jeff Hammel]

Attachment: include a (dummy) report type

adds in a dummy report type

Comment 9

[Jeff Hammel]

(In reply to comment #7)
> If you could simply include "mozmill-test" as report type it would be great.

see comment #8

Comment 10

[Andrew Halberstadt [:ahal]]

Comment on attachment 519726 [details] [diff] [review]
include a (dummy) report type

r+

Comment 11

[Jeff Hammel]

(In reply to comment #9)
> (In reply to comment #7)
> > If you could simply include "mozmill-test" as report type it would be great.
> 
> see comment #8

pushed to master: https://github.com/mozautomation/mozmill/commit/81e14ef3f80f1097ab763ec36ad1ee480232216e

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Looks good. Thanks Jeff!