640260 - Toolbar icon briefly appear on startup with TP enabled

Status: RESOLVED WONTFIX

(Mozilla Labs Graveyard :: Test Pilot, defect)

Description

[Tracy Walker [:tracy]]

Attachment: toolbar icon cluster on startup

Seen with 1.1pre6 on XP and Win7

It's very quick, but does appear briefly on each startup with the latest version of TP enabled. If TP is disabled the bug goes away.

See attachment for screen shot

Comment 1

[Jono Xia]

Yeah I see this on Mac too. Looks like a regression since 1.1pre5.  I think I can fix it by putting back on one of the css files I removed.

Comment 2

[Tracy Walker [:tracy]]

looks fixed in 1.1pre7 build

Comment 3

[Jono Xia]

Attachment: Patch to mozilla-central to fix this bug

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 524915 [details] [diff] [review]
Patch to mozilla-central to fix this bug

based on comment 2 this looks to be fixed, but I have very little context to go on here. I assume something in feedback.css was breaking a moz-image-region rule.

Can you give me some hints as to why the change fixed the bug?

Comment 5

[Jono Xia]

mfinkle:  There was an earlier bug where text was appearing in an unreadable color (white on white) on Windows because a CSS style was being applied where it didn't belong.  Removing both of the CSS includes from browser.xul fixed this problem, but introduced the problem described above in this bug, that the toolbar icon cluster showed on startup.  So I made a second change to put back in one of the two CSS includes.

To save on patches, I bundled both changes into a single patch and attached to this bug because it was more recent.

It is actually the white-text-on-white that is fixed by the resulting combi-patch.  Sorry for the confusion.

Comment 6

[Jono Xia]

Landed?

Comment 7

[Adam Muntner [:adamm] (use NEEDINFO)]

decommissioned