Closed Bug 641219 Opened 13 years ago Closed 13 years ago

HTMLElement.getElementsByTagName broken with foreign children

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(1 file, 2 obsolete files)

Patch for checkin
4.03 KB, patch
Details | Diff | Splinter Review 
This case was missed in bug 499656.

        Attachment #518948 -
        Flags: review?(Olli.Pettay)

    
  
Whiteboard: [needs patch] → [needs review]

    
    

    
  
Comment on attachment 518948 [details] [diff] [review]
Fix HTMLElement.getElementsByTagName with foreign children

Perhaps Jonas could review this too.

        Attachment #518948 -
        Flags: review?(Olli.Pettay) → review?(jonas)

    
    

    
  
Why not simply remove the method?

    
    

    
  
Comment on attachment 518948 [details] [diff] [review]
Fix HTMLElement.getElementsByTagName with foreign children

Can't you completely remove this function and instead just let it be inherited?

r=me with that fixed.

        Attachment #518948 -
        Flags: review?(jonas) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch for checkin (obsolete)
        — 
          — Splinter Review
      

    


  
OK, thanks.

        Attachment #518948 -
        Attachment is obsolete: true

    
  
Depends on: post2.0
Whiteboard: [needs review] → [needs landing]

    
  
Keywords: checkin-needed
Whiteboard: [needs landing]

    
    

    
  


  

        Attachment #519199 -
        Attachment is obsolete: true
Flags: in-testsuite+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/0e831a3686fb
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
No longer depends on: post2.0
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: