641352 - Add nsHTMLTextAreaElement::IsValueEmpty const

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Add IsValueEmpty

Like for nsHTMLInputElement, it makes thing easier to read.
But unlike nsHTMLInputElement, it comes with perf improvement given that we don't check if the string is the empty string but if mValue is NULL (by calling nsTextEditorState::IsEmpty).

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 519041 [details] [diff] [review]
Add IsValueEmpty

r=me

Comment 3

[Mounir Lamouri (:mounir)]

Ehsan, nsTextEditorState::IsEmpty doesn't sound to do what I expected it to do (returning if nsTextEditorState value is empty). Did I misinterpreted this method? is it mis-named? or is it not working as expected?

Comment 4

[(no longer active)]

(In reply to comment #3)
> Ehsan, nsTextEditorState::IsEmpty doesn't sound to do what I expected it to do
> (returning if nsTextEditorState value is empty). Did I misinterpreted this
> method? is it mis-named? or is it not working as expected?

It is not the best named method in our tree for sure.  ;-)  But the only call site I can find for it expects it to work this way.

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Add IsValueEmpty

The only chunk that has been changed is:

+bool
+nsHTMLTextAreaElement::IsValueEmpty() const
+{
+  nsAutoString value;
+  GetValueInternal(value, PR_TRUE);
+
+  return value.IsEmpty();
+}

In the previous patch, it was returning mState.IsEmpty().

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 525438 [details] [diff] [review]
Add IsValueEmpty

r=me

Comment 7

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/ebe25dc723b5