641414 - Sort lists of branches, tests, and platforms in 'Add Test Data' dialog

Status: RESOLVED FIXED

(Webtools Graveyard :: Graph Server, defect, P3)

Description

[Nick Thomas [:nthomas] (UTC+12)]

In the custom chart builder, there are lists which are (probably) sorted by id in their respective tables. It would be much more human friendly to sort alphabetically.

Comment 1

[Robert Helmer [:rhelmer]]

One thing that the original design calls for but is not yet implemented is the ability to have "popular" branches/tests/platforms on top:

http://people.mozilla.com/~chowse/drop/webtools/graph-server/v2/04_add_data.png

I might try to land this at the same time, because I think it'd be unfortunate if this change made Firefox not be at the top anymore ;)

Comment 4

[Robert Helmer [:rhelmer]]

graphs.m.o is deprecated in favor of datazilla at this point; not actively working on this

Comment 5

[Matt Brubeck (:mbrubeck)]

Attachment: part 1: Sort the menu options by name

Note: Object.keys and Array.prototype.forEach are available in every widely used browser except IE8 and below.

Comment 6

[Matt Brubeck (:mbrubeck)]

Attachment: part 2: Filter out branches with no data

With part 1 applied, it becomes more obvious that the menu contains many branches that are useless because there are no tests associated with them.

Comment 7

[Robert Helmer [:rhelmer]]

This is great, thanks! Do you need me to land it?

Comment 8

[Matt Brubeck (:mbrubeck)]

Nope!

http://hg.mozilla.org/graphs/rev/d9cdce203e2d
http://hg.mozilla.org/graphs/rev/f53cd87a3b97