641487 - Per-OS top crashers lists

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Of course the top crash signatures are all Windows specific. So if I'm looking at them to see if a certain feature is crashing a lot, I can get the impression that everything is fine until I realize that it's crashing only on Mac/Linux, just not quite enough to beat the major Windows crashers.

I would suggest making the current top crashers list Windows-only (that's almost what it already unofficialy is) and adding other OSes below.

Comment 1

[Laura Thomson :laura]

Wait for 1.9 to see if we can do this with ES.

Comment 2

[Laura Thomson :laura]

Lars: take this into account for killwolf, but lower priority (it can wait).

Comment 3

[Brandon Savage [:brandon]]

Per Lars, pushing off to next release.

Comment 4

[Laura Thomson :laura]

Rob, I'd like to know how hard this is going to be (and then triage it more intelligently).  Can you take a look?

Comment 5

[Schalk Neethling [:espressive]]

Reading [:bjacob] comment, it seems that what is needed is to take the table that is currently displayed here https://crash-stats.mozilla.com/topcrasher/byversion/Firefox/3.5.13 and split it to be two seperate tables.

One showing only Windows crashes and the other non-Windows related crashes. Do I understand this correctly?

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Not sure: for examples, the volume of Mac crashes would probably still dwarf the volume of Linux crashes. I really think we need per-OS top-crashers-views, for each OS.

Comment 7

[Schalk Neethling [:espressive]]

[:bjacob] Makes sense, would like to also hear what KaiRo thinks about it.

Comment 8

[Robert Kaiser]

If we would have a parameter to call this page (linked somewhere reasonable) that makes us show the list for a single OS, I think we would have all we want. This would be similar to what we have for browser/plugin/content/all versions of those reports.

Comment 9

[Schalk Neethling [:espressive]]

Looking at the call to the web service for the topcrasher.php controller, it needs to be extended to also allow for an optional OS string to be passed:

Currently:
$resp = $service->get("${host}/topcrash/sig/trend/rank/p/${p}/v/${v}/type/${crash_type}/end/${end_date}/duration/${dur}/listsize/${limit}", 'json', $lifetime);

Extended:
$resp = $service->get("${host}/topcrash/sig/trend/rank/p/${p}/v/${v}/type/${crash_type}/end/${end_date}/duration/${dur}/listsize/${limit}/os/${os}", 'json', $lifetime);

I suppose one can also filter the response but, it might be better to do this on the DB side already. If an OS is not provided the service can simply return the result for all OS's as it currently does.

Comment 11

[Laura Thomson :laura]

Adrian, can you add the appropriate params to the m'ware call and then pass back over to Schalk?

Comment 12

[[DEACTIVATED] Adrian Gaudebert]

I think my part of the job is done: https://github.com/AdrianGaudebert/socorro/tree/641487-per-os-tcbs-2

Schalk, I'm passing the baby to you. Let me know if there's anything I need to do.

Comment 13

[Schalk Neethling [:espressive]]

[:kairo] One question regarding per os tcbs. When selecting the OS, does the product version fall away or should the results then still be for the currently selected version, just filtered further by the selected OS?

Comment 14

[Laura Thomson :laura]

Schalk: the latter.

Comment 15

[Robert Kaiser]

As Laura also says, it should act like the process type selector does as well and keep all other options intact. That is, when looking at topcrashers for Firefox 10.0b5, I expect that clicking "Linux" in a platform selector will take me to Firefox 10.0b5 Linux topcrashers, clicking "Mac" will take me to FF 10.0b5 Mac TCBS, and "All" (or so) will take me back to the total FF 10.0b5 TCBS page.

Comment 16

[Schalk Neethling [:espressive]]

Attachment: per os top crashers

This is where I am at currently, everything works, just have some more tweaks I want to make that can be filtered into the other areas if it proves good.

Comment 17

[Schalk Neethling [:espressive]]

Sent pull request: https://github.com/mozilla/socorro/pull/332

Test case coming soon.

Comment 18

[[:jberkus] Josh Berkus]

This should be able to be done using the existing TCBS table without any new database support.

Comment 19

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/3e0e85246666f21f4b847d9cb3cec17909ea363c
Merge pull request #332 from ossreleasefeed/per-os-tcbs

Per os tcbs fixes bug 641487

Comment 20

[Robert Helmer [:rhelmer]]

(In reply to [github robot] from comment #19)
> Commit pushed to master at https://github.com/mozilla/socorro
> 
> https://github.com/mozilla/socorro/commit/
> 3e0e85246666f21f4b847d9cb3cec17909ea363c
> Merge pull request #332 from ossreleasefeed/per-os-tcbs
> 
> Per os tcbs fixes bug 641487

BTW the three config files in this changeset need to be merged to stage config, so I have added an entry to https://wiki.mozilla.org/Socorro:Releases/2.4.2#config_changes 

topcrashers.php
platforms.php
routes.php

crash-stats-dev selectively overrides so it doesn't break there; we should either make stage and prod do the same, or make c-s-d always override so it breaks and we know :) will file a separate bug for that.

Comment 21

[Schalk Neethling [:espressive]]

TEST CASE
---------

Head to top crashers
Here there will be a new filter for OS containing:
Window Linux Mac OS X

Clicking on one of these will take you to the new per os top crashers page. The OS filter on this page will have one new addition called 'All'. Clicking on this will take you back to the top crashers page retaining the product, version, type and duration.

Back on the per os page, the content will be much the same as the current top crashers but, there are some columns that are not shows such as count. You should also see crash numbers only for the current selected OS.

Clicking on the different OS links will reload the page showing crashes only for that OS. The type and duration links should here work the same as they do on top crashers.

There are also some subtle UI changes to look out for here. The up and down trend is not shown as an up or down arrow next to the row and no longer on the trend column.

Opening a graph under signature will now show a different display as well as providing the option to close the graph. Once a graph has been closed, you should be presented again with the option to show the graph.

When sorting per column using the table sorter the rows should always retain their proper alternate row colors.

I believe this covers everything that needs to be checked however, if there is anything that seems odd or not work as expected, please let me know.

Comment 22

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

Bumping to qa verified. Thanks sckulk for the excellent description of what behavior changed in the app, comment 21.

:austind and I will file some feature enhancement bugs based off of the conversation in the channel.