641735 - Auto-publisher broken due to Collections API error

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: API, defect, P1)

Description

[David McNamara [:mackers]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-GB; rv:1.9.2.13) Gecko/20101203 Firefox/3.6.13
Build Identifier: 

The auto-publisher feature of the Collector extension is not working correctly due to an API error.

Reproducible: Always

Steps to Reproduce:
1. create an auto publisher
2. wait for collections to sync or restart firefox

Actual Results:  
The auto-publisher collection is created, but no extensions are added to the collection.

Expected Results:  
The auto-publisher collection is created and locally installed extensions are added to it.

This appears to be an API bug. The collector follows the API as specified in:

https://developer.mozilla.org/en/addons.mozilla.org_%28AMO%29_API_Developers%27_Guide/The_Bandwagon_API#Adding_an_addon_to_a_collection

Here is the debug output:

bandwagon(DEBUG): [API] send: opening POST XMLHttpRequest to https://addons.mozilla.org/en-US/firefox/api/1.3/sharing//collections/ae57a1d1-6fe0-b50b-1c22-b39e7474b25c/addons/?guid=%7B2522f048-c952-d742-8979-6f7206c86c70%7D&comments=&__=1300158328534

bandwagon(DEBUG): [API] send: completed, response text = '<?xml version="1.0" encoding="utf-8" ?>
<error xmlns="http://addons.mozilla.org/" 
    reason="invalid_parameters"
    details="" 
     
/>
 

Note that this API call used to work (upon previous collector release) - I don't think the format of the API call has changed on the client side since then.

Comment 1

[Brian King [:kinger]]

Escalating this issue as a blocker to the imminent Collector release for Firefox 4.

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Can you explain the call to me:

 https://addons.mozilla.org/en-US/firefox/api/1.3/sharing//collections/ae57a1d1-6fe0-b50b-1c22-b39e7474b25c/addons/?guid=%7B2522f048-c952-d742-8979-6f7206c86c70%7D&comments=&__=1300158328534

what is the ae57... UUID and what is the {2522f048- uuid?

I'll try to piece together what I can.

Comment 3

[David McNamara [:mackers]]

The call follows the Bandwagon API call to add an addon to a collection. See:

https://developer.mozilla.org/en/addons.mozilla.org_%28AMO%29_API_Developers%27_Guide/The_Bandwagon_API#Adding_an_addon_to_a_collection

In this case:

ae57a1d1-6fe0-b50b-1c22-b39e7474b25c is the collection
{2522f048-c952-d742-8979-6f7206c86c70} is the addon

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Where can I get the build of collector that you are using.

Ping me on IRC, this bug is a rabbit-hole for me, as I'd need to figure out some details with the collector in addition to getting remora set up locally, so I can figure out what's going on.

Comment 5

[Brian King [:kinger]]

(In reply to comment #4)
> Where can I get the build of collector that you are using.

Sent via email.

Comment 6

[Justin Scott [:fligtar]]

This is the only thing in the way of releasing the Collector update for Firefox 4. We should push this today.

Comment 7

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Brian - I didn't get it - try sending it to my personal email - [e-mail].

Comment 8

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

If either of you are on IRC today that would probably help me a lot.

Comment 9

[Wil Clouser [:clouserw]]

Brian, can you get online?

Fwiw, it doesn't sound like this is going to make our push, which goes out in 2 hours.

Comment 10

[Brian King [:kinger]]

(In reply to comment #7)
> Brian - I didn't get it - try sending it to my personal email -
> [e-mail].

Done.

Comment 11

[Justin Scott [:fligtar]]

Brian, Dave and I are able to publish with our auto-publishers. Can you describe what the problem is in more detail or get on irc?

Comment 12

[Brian King [:kinger]]

David,

It seems like everything is working except this display of the collection after first creation. Can you confirm? It displays after a refresh.

Comment 13

[David McNamara [:mackers]]

Ok, the auto-published is working for me now. I see my extensions in the auto publisher collection. Not sure why it wasn't working before.

The "invalid_parameters" error was a slightly separate issue caused by the extension attempting to publish plugins. I've fixed that in r85492.

Brian, the issue with the extensions not appearing immediately has always been an issue AFAIR - maybe due to some server delay or caching? We could open a separate bug to track that.

Comment 14

[Brian King [:kinger]]

(In reply to comment #13)
> Brian, the issue with the extensions not appearing immediately has always been
> an issue AFAIR - maybe due to some server delay or caching? We could open a
> separate bug to track that.

Bug 642881.