Closed
Bug 641942
Opened 13 years ago
Closed 13 years ago
Make Windows progress bars RTL-friendly
Categories
(Core :: Widget: Win32, defect)
Core
Widget: Win32
Tracking
()
VERIFIED
FIXED
mozilla6
People
(Reporter: mounir, Assigned: mounir)
References
()
Details
(Keywords: rtl)
Attachments
(1 file)
1.54 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
They are shown with the bar on the right because this is managed by the layout code but the animations are done by the widget code and currently do not take into account RTL.
Assignee | ||
Comment 2•13 years ago
|
||
<progress value=0.5> in LTR will be shown like: [***** ] In RTL: [ *****] But, on Windows (Vista and later), there is animated glow on the progress bars which, for the moment, goes from left to right. In addition, indeterminate progress bars also go from left to right. You can try the URL with this build to have a look: https://ftp.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/mlamouri@mozilla.com-3665ab582961/
Assignee | ||
Comment 3•13 years ago
|
||
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
Attachment #519977 -
Flags: review?(jmathies)
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs review]
Comment 4•13 years ago
|
||
(In reply to comment #2) > <progress value=0.5> in LTR will be shown like: > [***** ] > In RTL: > [ *****] > > But, on Windows (Vista and later), there is animated glow on the progress bars > which, for the moment, goes from left to right. I see, makes sense.
Comment 5•13 years ago
|
||
Comment on attachment 519977 [details] [diff] [review] Patch v1 Review of attachment 519977 [details] [diff] [review]: r+
Attachment #519977 -
Flags: review?(jmathies) → review+
Updated•13 years ago
|
Whiteboard: [needs review]
Assignee | ||
Comment 6•13 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/ea4a5a20e081
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Comment 7•13 years ago
|
||
Backed out in http://hg.mozilla.org/mozilla-central/rev/dd9ba28d2bd9 to resolve bug 655860.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 8•13 years ago
|
||
The regression wasn't caused by these patches. Re-landed: http://hg.mozilla.org/mozilla-central/rev/e0b0a18a6905
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Comment 9•13 years ago
|
||
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20100101 Firefox/6.0 Checked this issue using an 'ar' Fx 6.0b2 build. Yes, the animation is moving from right to left as it should be, but what concerns me is that it doesn't have a consistent pattern - sometimes it disappears and reapers a few centimeters away, it doesn't always start from the beginning of the progress bar. Considering this, I am setting the status of the bug to Reopened.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 10•13 years ago
|
||
(In reply to comment #9) > Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20100101 Firefox/6.0 > > Checked this issue using an 'ar' Fx 6.0b2 build. > > Yes, the animation is moving from right to left as it should be, but what > concerns me is that it doesn't have a consistent pattern - sometimes it > disappears and reapers a few centimeters away, it doesn't always start from > the beginning of the progress bar. > > Considering this, I am setting the status of the bug to Reopened. Could you file a new bug George and mark it as blocking this one? (Lets keep this one closed since patches landed here.)
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Comment 11•13 years ago
|
||
Logged Bug 672782. Setting the resolution of this issue to Verified Fixed, as RTL animation was introduced.
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•