641998 - Locales are not displayed on Facebook Badges page

Status: VERIFIED FIXED

(Websites :: Facebook, defect)

Description

[Staś Małolepszy :stas]

+++ This bug was initially created as a clone of Bug #641119 +++

https://www.facebook.com/pages/Firefox-4/130379370362344?sk=app_122300121174636 is always in English, independently of the user's prefs on fb.

Comment 1

[Staś Małolepszy :stas]

In case anyone gets to this before I wake up:

Looking at the code at <https://svn.mozilla.org/projects/mozilla.com/branches/firefox4/en-US/firefox/fb-badges/index.html>, please change

    /* Set the Locale */
    $locale = $user["user"]["locale"];
    
    putenv("LC_ALL=" . $locale);
    setlocale(LC_ALL, $locale);

to 

    /* Set the Locale */
    $locale = $user["user"]["locale"];
    echo $locale;
    
    putenv("LC_ALL=" . $locale);
    echo setlocale(LC_ALL, $locale);
   
What does it echo when you access <https://www.facebook.com/pages/Firefox-4/130379370362344?sk=app_122300121174636>?

Can you repeat this after temporarily changing your lang prefs on Facebook to a different locale than en-US?

Thanks!

Comment 2

[Staś Małolepszy :stas]

I debugged this with Shyam and it turned out to be a bug in the code.  I'll attach a patch in a sec.

Comment 3

[Staś Małolepszy :stas]

Attachment: Look for locales in the right dir

Comment 4

[Fred Wenzel [:wenzel]]

Assigning to Zach so he imports it into the upstream SVN.

Comment 5

[Staś Małolepszy :stas]

Any chance that this can be fixed today, please?

Comment 6

[Matt Brandt [:mbrandt]]

(In reply to comment #5)
> Any chance that this can be fixed today, please?

Zach has been emailed ... I think we're waiting on him or has this already been committed to svn?

Comment 7

[William Reynolds [:williamr]]

Update: just talked with Zach and he's going to have this patched in the next couple hours. He's also tweaking the CSS styles for locales. Stand by.

Comment 8

[Staś Małolepszy :stas]

(In reply to comment #7)
> He's also tweaking the CSS styles for locales.

In fact, I don't think he should do this.  If he applies the patch Gandalf sent by email to enable custom-css, localizers and the l10n team will be able to tweak the CSS instead.

Comment 9

[Zach Allia]

commited gandalf's fix and this fix

Comment 10

[Fred Wenzel [:wenzel]]

I pulled the L10n-related commit into our SVN in r85307.

Comment 11

[Staś Małolepszy :stas]

w00t!  The stage works now!

Comment 12

[Matt Brandt [:mbrandt]]

Nice! Both William and I see this awesomeness working... marking QA Verified so we can kick off the formal test cycle.