Closed Bug 64260 Opened 24 years ago Closed 24 years ago

NSS users should not include cdbhdl.h.

Categories

(NSS :: Libraries, defect, P1)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: rrelyea)

References

Details

Attachments

(3 files)

Some NSS users have had to include the
internal NSS header cdbhdl.h so that they
can allocate a CERTCertDBHandle structure
and pass its address to the cert database
open functions such as CERT_OpenCertDB(),
CERT_OpenCertDBFilename(), and
CERT_OpenVolatileCertDB().

The reason why these NSS users have to call
the cert db open functions directly is that 
the preferred method of using NSS_Init()
doesn't support the naming convention in use
by these NSS users.  Two possible solutions are:
1) Change the cert db open calls to allocate and
return the handle (as is done in the key db interface) -or-
2) Add calls to similar to NSS_Init() that allow the
NSS users to use the current naming convention without
making direct calls to the cert db open interface.

This issue must be resolved before we release
NSS 3.2 Beta.
Priority: -- → P1
Target Milestone: --- → 3.2
Severity: blocker → major
Turns out that we have previously agreed to implement
solution #2.
Bob has written the new NSS_Initialize() function.
I think we can mark this bug fixed.
Assignee: kirke → relyea
*** Bug 56330 has been marked as a duplicate of this bug. ***
Here are the 'last' of the cmd files which included the header (dbck.c was not
changed because it isn't compiled, but is an internal tool that does need this
private header).
Status: NEW → ASSIGNED
The patch is good.

Bob, should we move cdbhdl.h from EXPORTS to PRIVATE_EXPORTS?
Does any of our client (such as PSM or JSS) need it?
Do we need to worry about instinit and newuser?
JSS still uses this header file, but we can still get at it if it is a 
PRIVATE_EXPORT.
This patch is good.
Amen.
cdbhdl.h is now on the private exports list.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: