Closed
Bug 64260
Opened 24 years ago
Closed 24 years ago
NSS users should not include cdbhdl.h.
Categories
(NSS :: Libraries, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
3.2
People
(Reporter: wtc, Assigned: rrelyea)
References
Details
Attachments
(3 files)
1.66 KB,
patch
|
Details | Diff | Splinter Review | |
3.64 KB,
patch
|
Details | Diff | Splinter Review | |
473 bytes,
patch
|
Details | Diff | Splinter Review |
Some NSS users have had to include the internal NSS header cdbhdl.h so that they can allocate a CERTCertDBHandle structure and pass its address to the cert database open functions such as CERT_OpenCertDB(), CERT_OpenCertDBFilename(), and CERT_OpenVolatileCertDB(). The reason why these NSS users have to call the cert db open functions directly is that the preferred method of using NSS_Init() doesn't support the naming convention in use by these NSS users. Two possible solutions are: 1) Change the cert db open calls to allocate and return the handle (as is done in the key db interface) -or- 2) Add calls to similar to NSS_Init() that allow the NSS users to use the current naming convention without making direct calls to the cert db open interface. This issue must be resolved before we release NSS 3.2 Beta.
Reporter | ||
Updated•24 years ago
|
Priority: -- → P1
Target Milestone: --- → 3.2
Reporter | ||
Updated•24 years ago
|
Severity: blocker → major
Reporter | ||
Comment 1•24 years ago
|
||
Turns out that we have previously agreed to implement solution #2.
Reporter | ||
Comment 2•24 years ago
|
||
Bob has written the new NSS_Initialize() function. I think we can mark this bug fixed.
Assignee: kirke → relyea
Assignee | ||
Comment 4•24 years ago
|
||
Assignee | ||
Comment 5•24 years ago
|
||
Here are the 'last' of the cmd files which included the header (dbck.c was not changed because it isn't compiled, but is an internal tool that does need this private header).
Status: NEW → ASSIGNED
Reporter | ||
Comment 6•24 years ago
|
||
The patch is good. Bob, should we move cdbhdl.h from EXPORTS to PRIVATE_EXPORTS? Does any of our client (such as PSM or JSS) need it?
Reporter | ||
Comment 7•24 years ago
|
||
Do we need to worry about instinit and newuser?
Comment 8•24 years ago
|
||
JSS still uses this header file, but we can still get at it if it is a PRIVATE_EXPORT.
Assignee | ||
Comment 9•24 years ago
|
||
Reporter | ||
Comment 10•24 years ago
|
||
This patch is good.
Assignee | ||
Comment 11•24 years ago
|
||
Reporter | ||
Comment 12•24 years ago
|
||
Amen.
Assignee | ||
Comment 13•24 years ago
|
||
cdbhdl.h is now on the private exports list.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•