Closed
Bug 643761
Opened 13 years ago
Closed 13 years ago
Move snapToGrid, pageProperties and publishSettings from editorOverlay to editor
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b3
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
|
10.18 KB,
patch
|
neil
:
review+
Bienvenu
:
review+
|
Details | Diff | Splinter Review |
The elements snapToGrid, pageProperties and publishSettings are only used by Composer and not by messagecompose or the text editor so should be moved out of editorOverlay and into editor. This patch does that and moves their entities too.
Attachment #520923 -
Flags: review?(neil)
Attachment #520923 -
Flags: review?(bugzilla)
Attachment #520923 -
Flags: review?(neil)
Attachment #520923 -
Flags: review?(bugzilla)
Changes since v1.0: * Forgot about cmd_propertiesPage command so move it too.
Attachment #520923 -
Attachment is obsolete: true
Attachment #520956 -
Flags: review?(neil)
Attachment #520956 -
Flags: review?(neil)
Changes since v1.1: * As publish is wanted in the text editor then publishSettings should be available in it to, so move publishSettings into editorOverlay.
Attachment #520956 -
Attachment is obsolete: true
Attachment #522254 -
Flags: review?(neil)
|
||
Updated•13 years ago
|
Attachment #522254 -
Flags: review?(neil) → review+
Comment on attachment 522254 [details] [diff] [review] Move snapToGrid, pageProperties and publishSettings patch v1.2 [Checked in: Comment 4] Requesting r for entity changes that affect TB
Attachment #522254 -
Flags: review?(bugzilla)
Attachment #522254 -
Flags: review?(bugzilla) → review?(bienvenu)
|
||
Updated•13 years ago
|
Attachment #522254 -
Flags: review?(bienvenu) → review+
Attachment #522254 -
Attachment description: Move snapToGrid, pageProperties and publishSettings patch v1.2 → Move snapToGrid, pageProperties and publishSettings patch v1.2 [Checked in: Comment 4]
Comment on attachment 522254 [details] [diff] [review] Move snapToGrid, pageProperties and publishSettings patch v1.2 [Checked in: Comment 4] http://hg.mozilla.org/comm-central/rev/0b6d0aee59eb
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b3
You need to log in
before you can comment on or make changes to this bug.
Description
•