Closed
Bug 643890
Opened 13 years ago
Closed 13 years ago
Use Apache's ErrorLog when using mod_perl/vhosts
Categories
(Bugzilla :: Administration, task)
Bugzilla
Administration
Tracking
()
RESOLVED
FIXED
Bugzilla 4.2
People
(Reporter: idl0r, Assigned: idl0r)
References
()
Details
Attachments
(1 file)
714 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:2.0) Gecko/20110322 Firefox/4.0 Build Identifier: All errors will be logged in apache's global error log instead of the ErrorLog of the specified vhost. See URL for further information. Reproducible: Always
Updated•13 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 1•13 years ago
|
||
We're using this patch currently
Updated•13 years ago
|
Attachment #521259 -
Flags: review?(mkanat)
Comment 2•13 years ago
|
||
Comment on attachment 521259 [details] [diff] [review] 0001-Use-apache-s-ErrorLog.patch Review of attachment 521259 [details] [diff] [review]: ----------------------------------------------------------------- ::: mod_perl.pl @@ +56,5 @@ > use Bugzilla::Template (); > use Bugzilla::Util (); > > +use Apache2::Log (); > +*CORE::GLOBAL::warn = \&Apache2::ServerRec::warn; Looks good. We should put the CORE::GLOBAL::warn in a BEGIN block, though. That can be done on checkin.
Attachment #521259 -
Flags: review?(mkanat) → review+
Comment 3•13 years ago
|
||
It's *sort* of a bug that log messages go to the wrong place. At least 4.2 should get this fix.
Flags: approval+
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → Bugzilla 4.2
Updated•13 years ago
|
Assignee: administration → idl0r
Status: NEW → ASSIGNED
Comment 4•13 years ago
|
||
mkanat, as you reviewed the patch and a fix on checkin is needed, could you please commit this patch yourself?
Comment 5•13 years ago
|
||
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/ modified mod_perl.pl Committed revision 7860.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•