Closed
Bug 644063
Opened 13 years ago
Closed 13 years ago
Bring back some VM code which AOT depends on
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: almancha, Unassigned)
Details
Attachments
(1 file)
|
2.53 KB,
patch
|
stejohns
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.151 Safari/534.16 Build Identifier: AOT depended on some code which was ifdef-ed under VMCFG_INDIRECT_NATIVE_THUNKS and removed in CL#851319. Specifically the AvmThunkNativeHandler handler member of struct NativeMethodInfo. Bringing it back under VMCFG_AOT to fix AOT break in FRmain. Reproducible: Always
|
Reporter | |
Comment 1•13 years ago
|
||
Attachment #521118 -
Flags: review?(stejohns)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 521118 [details] [diff] [review] Proposed fix (bring back handler member of NativeMedhodInfo) Looks good, want me to push it for you?
Attachment #521118 -
Flags: review?(stejohns) → review+
|
|
Reporter | |
Comment 3•13 years ago
|
||
Yes please! Thanks so much for the quick turnaround Steven. (In reply to comment #2) > Comment on attachment 521118 [details] [diff] [review] > Proposed fix (bring back handler member of NativeMedhodInfo) > > Looks good, want me to push it for you?
|
|
||
Comment 4•13 years ago
|
||
TR 6125:21a43c83ec14
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•