64479 - Clean up some bookmarks stuff

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Blake Ross]

Attaching a patch for some clean-up and a couple bugfixes.

Comment 1

[Blake Ross]

oops

Comment 2

[Blake Ross]

Attachment: [patch] cleanup

Comment 3

[Blake Ross]

Attachment: [patch] -bw

Comment 4

[Blake Ross]

This fixes 57191, and an as-yet (I think) unreported bug -- the custom keywords 
option shouldn't be visible in the tree, the menulist or the menu if you're 
searching history.  I did this in a generic enough way that it eventually could 
apply to hiding more items and different search types (e.g. when you want to 
search history for last visited, etc., which you probably wouldn't want to do 
with bookmarks -- i'll file that soon), although we may eventually just bite 
the bullet and split bookmarks and history search into two separate windows.

anyways, cc'ing alec for sr.

Comment 5

[Blake Ross]

cc'ing timeless for r=, yes I will fix the newline, yes I will fix every 
possible spacing problem on earth...

Comment 6

[Alec Flett]

sr=alecf

Comment 7

[Blake Ross]

fix checked in.

Comment 8

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]