Closed
Bug 644931
Opened 13 years ago
Closed 13 years ago
Add Sharing UI to Firefox
Categories
(Cloud Services :: Share: Firefox Client, defect)
Cloud Services
Share: Firefox Client
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philikon, Assigned: philikon)
References
Details
Attachments
(1 file)
9.26 KB,
patch
|
clarkbw
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•13 years ago
|
||
This adds the F1 navbar button and the File/App menu item to Firefox. It does *not* add the content area context menu item or anything else, mostly because I wanted to be conservative in what UI bits we add to Firefox (especially since the UX may easily change in the next few days). I preemptively landed this in the project repo as https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/ee945eb938e9. I also landed the theming bits based on the add-on: https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/ba465d64fc75. This will *definitely* change so I'm not even bothering asking for review on that one.
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to comment #1) > I also landed the theming bits based on the add-on: > https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/ba465d64fc75. > This will *definitely* change so I'm not even bothering asking for review on > that one. Just landed a small follow-up to that: https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/79d6b464a11e
Comment 3•13 years ago
|
||
Comment on attachment 521756 [details] [diff] [review] v1 looks good. r=clarkbw
Attachment #521756 -
Flags: review?(clarkbw) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Thanks, Bryan.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•